Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2015 Google Inc. All rights reserved. 2 * Copyright (C) 2015 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 } 333 }
334 334
335 bool HTMLSlotElement::findHostChildWithSameSlotName() const { 335 bool HTMLSlotElement::findHostChildWithSameSlotName() const {
336 ShadowRoot* root = containingShadowRoot(); 336 ShadowRoot* root = containingShadowRoot();
337 DCHECK(root); 337 DCHECK(root);
338 DCHECK(root->isV1()); 338 DCHECK(root->isV1());
339 SlotAssignment& assignment = root->ensureSlotAssignment(); 339 SlotAssignment& assignment = root->ensureSlotAssignment();
340 return assignment.findHostChildBySlotName(name()); 340 return assignment.findHostChildBySlotName(name());
341 } 341 }
342 342
343 short HTMLSlotElement::tabIndex() const { 343 int HTMLSlotElement::tabIndex() const {
344 return Element::tabIndex(); 344 return Element::tabIndex();
345 } 345 }
346 346
347 DEFINE_TRACE(HTMLSlotElement) { 347 DEFINE_TRACE(HTMLSlotElement) {
348 visitor->trace(m_assignedNodes); 348 visitor->trace(m_assignedNodes);
349 visitor->trace(m_distributedNodes); 349 visitor->trace(m_distributedNodes);
350 visitor->trace(m_oldDistributedNodes); 350 visitor->trace(m_oldDistributedNodes);
351 visitor->trace(m_distributedIndices); 351 visitor->trace(m_distributedIndices);
352 HTMLElement::trace(visitor); 352 HTMLElement::trace(visitor);
353 } 353 }
354 354
355 } // namespace blink 355 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698