Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
6 * reserved. 6 * reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 void setNeedsWillValidateCheck(); 170 void setNeedsWillValidateCheck();
171 virtual bool recalcWillValidate() const; 171 virtual bool recalcWillValidate() const;
172 172
173 virtual void resetImpl() {} 173 virtual void resetImpl() {}
174 virtual bool supportsAutofocus() const; 174 virtual bool supportsAutofocus() const;
175 175
176 private: 176 private:
177 bool isFormControlElement() const final { return true; } 177 bool isFormControlElement() const final { return true; }
178 bool alwaysCreateUserAgentShadowRoot() const override { return true; } 178 bool alwaysCreateUserAgentShadowRoot() const override { return true; }
179 179
180 short tabIndex() const; 180 int tabIndex() const;
181 181
182 bool isValidElement() override; 182 bool isValidElement() override;
183 bool matchesValidityPseudoClasses() const override; 183 bool matchesValidityPseudoClasses() const override;
184 void updateAncestorDisabledState() const; 184 void updateAncestorDisabledState() const;
185 185
186 bool isValidationMessageVisible() const; 186 bool isValidationMessageVisible() const;
187 ValidationMessageClient* validationMessageClient() const; 187 ValidationMessageClient* validationMessageClient() const;
188 188
189 // Requests validity recalc for the form owner, if one exists. 189 // Requests validity recalc for the form owner, if one exists.
190 void formOwnerSetNeedsValidityCheck(); 190 void formOwnerSetNeedsValidityCheck();
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement); 223 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement);
224 DEFINE_TYPE_CASTS(HTMLFormControlElement, 224 DEFINE_TYPE_CASTS(HTMLFormControlElement,
225 FormAssociatedElement, 225 FormAssociatedElement,
226 control, 226 control,
227 control->isFormControlElement(), 227 control->isFormControlElement(),
228 control.isFormControlElement()); 228 control.isFormControlElement());
229 229
230 } // namespace blink 230 } // namespace blink
231 231
232 #endif 232 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698