Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLElement.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004-2007, 2009, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2004-2007, 2009, 2014 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 DEFINE_WRAPPERTYPEINFO(); 43 DEFINE_WRAPPERTYPEINFO();
44 44
45 public: 45 public:
46 DECLARE_ELEMENT_FACTORY_WITH_TAGNAME(HTMLElement); 46 DECLARE_ELEMENT_FACTORY_WITH_TAGNAME(HTMLElement);
47 47
48 bool hasTagName(const HTMLQualifiedName& name) const { 48 bool hasTagName(const HTMLQualifiedName& name) const {
49 return hasLocalName(name.localName()); 49 return hasLocalName(name.localName());
50 } 50 }
51 51
52 String title() const final; 52 String title() const final;
53 short tabIndex() const override; 53 int tabIndex() const override;
54 54
55 void setInnerText(const String&, ExceptionState&); 55 void setInnerText(const String&, ExceptionState&);
56 void setOuterText(const String&, ExceptionState&); 56 void setOuterText(const String&, ExceptionState&);
57 57
58 virtual bool hasCustomFocusLogic() const; 58 virtual bool hasCustomFocusLogic() const;
59 59
60 String contentEditable() const; 60 String contentEditable() const;
61 void setContentEditable(const String&, ExceptionState&); 61 void setContentEditable(const String&, ExceptionState&);
62 // For HTMLElement.prototype.isContentEditable. This matches to neither 62 // For HTMLElement.prototype.isContentEditable. This matches to neither
63 // blink::isContentEditable() nor blink::isContentRichlyEditable(). Do not 63 // blink::isContentEditable() nor blink::isContentRichlyEditable(). Do not
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 inline bool isElementOfType<const thisType>(const HTMLElement& element) { \ 230 inline bool isElementOfType<const thisType>(const HTMLElement& element) { \
231 return is##thisType(element); \ 231 return is##thisType(element); \
232 } \ 232 } \
233 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType) 233 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType)
234 234
235 } // namespace blink 235 } // namespace blink
236 236
237 #include "core/HTMLElementTypeHelpers.h" 237 #include "core/HTMLElementTypeHelpers.h"
238 238
239 #endif // HTMLElement_h 239 #endif // HTMLElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698