Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
6 * rights reserved. 6 * rights reserved.
7 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 7 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * 10 *
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 DCHECK(m_data.m_rareData); 297 DCHECK(m_data.m_rareData);
298 setFlag(HasRareDataFlag); 298 setFlag(HasRareDataFlag);
299 ScriptWrappableVisitor::writeBarrier(this, rareData()); 299 ScriptWrappableVisitor::writeBarrier(this, rareData());
300 return *rareData(); 300 return *rareData();
301 } 301 }
302 302
303 Node* Node::toNode() { 303 Node* Node::toNode() {
304 return this; 304 return this;
305 } 305 }
306 306
307 short Node::tabIndex() const { 307 int Node::tabIndex() const {
308 return 0; 308 return 0;
309 } 309 }
310 310
311 String Node::nodeValue() const { 311 String Node::nodeValue() const {
312 return String(); 312 return String();
313 } 313 }
314 314
315 void Node::setNodeValue(const String&) { 315 void Node::setNodeValue(const String&) {
316 // By default, setting nodeValue has no effect. 316 // By default, setting nodeValue has no effect.
317 } 317 }
(...skipping 2149 matching lines...) Expand 10 before | Expand all | Expand 10 after
2467 if (node) { 2467 if (node) {
2468 std::stringstream stream; 2468 std::stringstream stream;
2469 node->printNodePathTo(stream); 2469 node->printNodePathTo(stream);
2470 LOG(INFO) << stream.str(); 2470 LOG(INFO) << stream.str();
2471 } else { 2471 } else {
2472 LOG(INFO) << "Cannot showNodePath for <null>"; 2472 LOG(INFO) << "Cannot showNodePath for <null>";
2473 } 2473 }
2474 } 2474 }
2475 2475
2476 #endif 2476 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698