Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2003-2011, 2013, 2014 Apple Inc. All rights reserved. 6 * Copyright (C) 2003-2011, 2013, 2014 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 659 matching lines...) Expand 10 before | Expand all | Expand 10 after
670 ElementAnimations* elementAnimations() const; 670 ElementAnimations* elementAnimations() const;
671 ElementAnimations& ensureElementAnimations(); 671 ElementAnimations& ensureElementAnimations();
672 bool hasAnimations() const; 672 bool hasAnimations() const;
673 673
674 void synchronizeAttribute(const AtomicString& localName) const; 674 void synchronizeAttribute(const AtomicString& localName) const;
675 675
676 MutableStylePropertySet& ensureMutableInlineStyle(); 676 MutableStylePropertySet& ensureMutableInlineStyle();
677 void clearMutableInlineStyleIfEmpty(); 677 void clearMutableInlineStyleIfEmpty();
678 678
679 void setTabIndex(int); 679 void setTabIndex(int);
680 short tabIndex() const override; 680 int tabIndex() const override;
681 681
682 // A compositor proxy is a very limited wrapper around an element. It 682 // A compositor proxy is a very limited wrapper around an element. It
683 // exposes only those properties that are requested at the time the proxy is 683 // exposes only those properties that are requested at the time the proxy is
684 // created. In order to know which properties are actually proxied, we 684 // created. In order to know which properties are actually proxied, we
685 // maintain a count of the number of compositor proxies associated with each 685 // maintain a count of the number of compositor proxies associated with each
686 // property. 686 // property.
687 bool hasCompositorProxy() const; 687 bool hasCompositorProxy() const;
688 void incrementCompositorProxiedProperties(uint32_t mutableProperties); 688 void incrementCompositorProxiedProperties(uint32_t mutableProperties);
689 void decrementCompositorProxiedProperties(uint32_t mutableProperties); 689 void decrementCompositorProxiedProperties(uint32_t mutableProperties);
690 uint32_t compositorMutableProperties() const; 690 uint32_t compositorMutableProperties() const;
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
750 virtual void willRecalcStyle(StyleRecalcChange); 750 virtual void willRecalcStyle(StyleRecalcChange);
751 virtual void didRecalcStyle(StyleRecalcChange); 751 virtual void didRecalcStyle(StyleRecalcChange);
752 virtual PassRefPtr<ComputedStyle> customStyleForLayoutObject(); 752 virtual PassRefPtr<ComputedStyle> customStyleForLayoutObject();
753 753
754 virtual bool shouldRegisterAsNamedItem() const { return false; } 754 virtual bool shouldRegisterAsNamedItem() const { return false; }
755 virtual bool shouldRegisterAsExtraNamedItem() const { return false; } 755 virtual bool shouldRegisterAsExtraNamedItem() const { return false; }
756 756
757 bool supportsSpatialNavigationFocus() const; 757 bool supportsSpatialNavigationFocus() const;
758 758
759 void clearTabIndexExplicitlyIfNeeded(); 759 void clearTabIndexExplicitlyIfNeeded();
760 void setTabIndexExplicitly(short); 760 void setTabIndexExplicitly(int);
761 // Subclasses may override this method to affect focusability. This method 761 // Subclasses may override this method to affect focusability. This method
762 // must be called on an up-to-date ComputedStyle, so it may use existence of 762 // must be called on an up-to-date ComputedStyle, so it may use existence of
763 // layoutObject and the LayoutObject::style() to reason about focusability. 763 // layoutObject and the LayoutObject::style() to reason about focusability.
764 // However, it must not retrieve layout information like position and size. 764 // However, it must not retrieve layout information like position and size.
765 // This method cannot be moved to LayoutObject because some focusable nodes 765 // This method cannot be moved to LayoutObject because some focusable nodes
766 // don't have layoutObjects. e.g., HTMLOptionElement. 766 // don't have layoutObjects. e.g., HTMLOptionElement.
767 // TODO(tkent): Rename this to isFocusableStyle. 767 // TODO(tkent): Rename this to isFocusableStyle.
768 virtual bool layoutObjectIsFocusable() const; 768 virtual bool layoutObjectIsFocusable() const;
769 769
770 // classAttributeChanged() exists to share code between 770 // classAttributeChanged() exists to share code between
(...skipping 381 matching lines...) Expand 10 before | Expand all | Expand 10 after
1152 #define DECLARE_ELEMENT_FACTORY_WITH_TAGNAME(T) \ 1152 #define DECLARE_ELEMENT_FACTORY_WITH_TAGNAME(T) \
1153 static T* create(const QualifiedName&, Document&) 1153 static T* create(const QualifiedName&, Document&)
1154 #define DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(T) \ 1154 #define DEFINE_ELEMENT_FACTORY_WITH_TAGNAME(T) \
1155 T* T::create(const QualifiedName& tagName, Document& document) { \ 1155 T* T::create(const QualifiedName& tagName, Document& document) { \
1156 return new T(tagName, document); \ 1156 return new T(tagName, document); \
1157 } 1157 }
1158 1158
1159 } // namespace blink 1159 } // namespace blink
1160 1160
1161 #endif // Element_h 1161 #endif // Element_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698