Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 23622037: Cleanup of some comparisons on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1722 matching lines...) Expand 10 before | Expand all | Expand 10 after
1733 ASSERT(value_cid_reg != kNoRegister); 1733 ASSERT(value_cid_reg != kNoRegister);
1734 if ((field_cid == kArrayCid) || (field_cid == kImmutableArrayCid)) { 1734 if ((field_cid == kArrayCid) || (field_cid == kImmutableArrayCid)) {
1735 // Destroy value_cid_reg (safe because we are finished with it). 1735 // Destroy value_cid_reg (safe because we are finished with it).
1736 __ ldr(value_cid_reg, 1736 __ ldr(value_cid_reg,
1737 FieldAddress(value_reg, Array::length_offset())); 1737 FieldAddress(value_reg, Array::length_offset()));
1738 } else if (RawObject::IsTypedDataClassId(field_cid)) { 1738 } else if (RawObject::IsTypedDataClassId(field_cid)) {
1739 // Destroy value_cid_reg (safe because we are finished with it). 1739 // Destroy value_cid_reg (safe because we are finished with it).
1740 __ ldr(value_cid_reg, 1740 __ ldr(value_cid_reg,
1741 FieldAddress(value_reg, TypedData::length_offset())); 1741 FieldAddress(value_reg, TypedData::length_offset()));
1742 } 1742 }
1743 __ LoadImmediate(IP, field_length); 1743 __ CompareImmediate(value_cid_reg, field_length);
1744 __ cmp(value_cid_reg, ShifterOperand(IP));
1745 if (ok_is_fall_through) { 1744 if (ok_is_fall_through) {
1746 __ b(fail, NE); 1745 __ b(fail, NE);
1747 } 1746 }
1748 } else { 1747 } else {
1749 // Nothing to emit. 1748 // Nothing to emit.
1750 ASSERT(!compiler->is_optimizing()); 1749 ASSERT(!compiler->is_optimizing());
1751 return; 1750 return;
1752 } 1751 }
1753 } 1752 }
1754 } 1753 }
(...skipping 2924 matching lines...) Expand 10 before | Expand all | Expand 10 after
4679 compiler->GenerateCall(token_pos(), 4678 compiler->GenerateCall(token_pos(),
4680 &label, 4679 &label,
4681 PcDescriptors::kOther, 4680 PcDescriptors::kOther,
4682 locs()); 4681 locs());
4683 __ Drop(2); // Discard type arguments and receiver. 4682 __ Drop(2); // Discard type arguments and receiver.
4684 } 4683 }
4685 4684
4686 } // namespace dart 4685 } // namespace dart
4687 4686
4688 #endif // defined TARGET_ARCH_ARM 4687 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698