Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: ui/aura/test/ui_controls_factory_aurax11.cc

Issue 23622035: x11: Prefer using ui::GetXDisplay() over getting the Display from the X11 message-pump. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/test/ui_controls_factory_aurax11.cc
diff --git a/ui/aura/test/ui_controls_factory_aurax11.cc b/ui/aura/test/ui_controls_factory_aurax11.cc
index 5dc8577aaa70c3946bcb55b893b7e74191d00b1e..ee977cf7ab6a4de2bc2a819b77f8c54a622a46d4 100644
--- a/ui/aura/test/ui_controls_factory_aurax11.cc
+++ b/ui/aura/test/ui_controls_factory_aurax11.cc
@@ -11,13 +11,13 @@
#endif
#include "base/logging.h"
-#include "base/message_loop/message_pump_x11.h"
#include "ui/aura/client/screen_position_client.h"
#include "ui/aura/env.h"
#include "ui/aura/root_window.h"
#include "ui/aura/test/ui_controls_factory_aura.h"
#include "ui/base/keycodes/keyboard_code_conversion_x.h"
#include "ui/base/test/ui_controls_aura.h"
+#include "ui/base/x/x11_util.h"
#include "ui/compositor/dip_util.h"
namespace aura {
@@ -73,7 +73,7 @@ class EventWaiter : public base::MessageLoopForUI::Observer {
// Returns atom that indidates that the XEvent is marker event.
Atom MarkerEventAtom() {
- return XInternAtom(base::MessagePumpX11::GetDefaultXDisplay(),
+ return XInternAtom(ui::GetXDisplay(),
"marker_event",
False);
oshima 2013/09/17 15:05:10 ditto
sadrul 2013/09/17 15:28:44 Done.
}
@@ -117,7 +117,7 @@ class UIControlsX11 : public UIControlsAura {
if (alt)
SetKeycodeAndSendThenMask(&xevent, XK_Alt_L, Mod1Mask);
xevent.xkey.keycode =
- XKeysymToKeycode(base::MessagePumpX11::GetDefaultXDisplay(),
+ XKeysymToKeycode(ui::GetXDisplay(),
ui::XKeysymForWindowsKeyCode(key, shift));
root_window_->PostNativeEvent(&xevent);
@@ -227,7 +227,7 @@ class UIControlsX11 : public UIControlsAura {
KeySym keysym,
unsigned int mask) {
xevent->xkey.keycode =
- XKeysymToKeycode(base::MessagePumpX11::GetDefaultXDisplay(),
+ XKeysymToKeycode(ui::GetXDisplay(),
keysym);
oshima 2013/09/17 15:05:10 ditto
sadrul 2013/09/17 15:28:44 Done.
root_window_->PostNativeEvent(xevent);
xevent->xkey.state |= mask;
@@ -238,7 +238,7 @@ class UIControlsX11 : public UIControlsAura {
KeySym keysym) {
xevent->xkey.state ^= mask;
xevent->xkey.keycode =
- XKeysymToKeycode(base::MessagePumpX11::GetDefaultXDisplay(),
+ XKeysymToKeycode(ui::GetXDisplay(),
keysym);
oshima 2013/09/17 15:05:10 ditto
sadrul 2013/09/17 15:28:44 Done.
root_window_->PostNativeEvent(xevent);
}

Powered by Google App Engine
This is Rietveld 408576698