x11: Prefer using ui::GetXDisplay() over getting the Display from the X11 message-pump.

x11: Prefer using ui::GetXDisplay() over getting the Display from the X11 message-pump.

BUG=none
R=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223621

[oshima, 2013-09-17 15:05:09]

lgtm with nits

https://codereview.chromium.org/23622035/diff/1/ash/display/mirror_window_con...
File ash/display/mirror_window_controller.cc (right):

https://codereview.chromium.org/23622035/diff/1/ash/display/mirror_window_con...
ash/display/mirror_window_controller.cc:51: window, event_mask);
can you make this single line?

https://codereview.chromium.org/23622035/diff/1/ui/aura/test/ui_controls_fact...
File ui/aura/test/ui_controls_factory_aurax11.cc (right):

https://codereview.chromium.org/23622035/diff/1/ui/aura/test/ui_controls_fact...
ui/aura/test/ui_controls_factory_aurax11.cc:78: False);
ditto

https://codereview.chromium.org/23622035/diff/1/ui/aura/test/ui_controls_fact...
ui/aura/test/ui_controls_factory_aurax11.cc:231: keysym);
ditto

https://codereview.chromium.org/23622035/diff/1/ui/aura/test/ui_controls_fact...
ui/aura/test/ui_controls_factory_aurax11.cc:242: keysym);
ditto

https://codereview.chromium.org/23622035/diff/1/ui/base/x/events_x.cc
File ui/base/x/events_x.cc (right):

https://codereview.chromium.org/23622035/diff/1/ui/base/x/events_x.cc#newcode265
ui/base/x/events_x.cc:265: "noop", False);
ditto

https://codereview.chromium.org/23622035/diff/1/ui/views/widget/desktop_aura/...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc (right):

https://codereview.chromium.org/23622035/diff/1/ui/views/widget/desktop_aura/...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:242:
source_window_, PropertyChangeMask);
ditto

[sadrul, 2013-09-17 15:28:44]

Thanks! Addressed all the nits.

https://codereview.chromium.org/23622035/diff/1/ash/display/mirror_window_con...
File ash/display/mirror_window_controller.cc (right):

https://codereview.chromium.org/23622035/diff/1/ash/display/mirror_window_con...
ash/display/mirror_window_controller.cc:51: window, event_mask);
On 2013/09/17 15:05:10, oshima wrote:
> can you make this single line?

Done.

https://codereview.chromium.org/23622035/diff/1/ui/aura/test/ui_controls_fact...
File ui/aura/test/ui_controls_factory_aurax11.cc (right):

https://codereview.chromium.org/23622035/diff/1/ui/aura/test/ui_controls_fact...
ui/aura/test/ui_controls_factory_aurax11.cc:78: False);
On 2013/09/17 15:05:10, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/23622035/diff/1/ui/aura/test/ui_controls_fact...
ui/aura/test/ui_controls_factory_aurax11.cc:231: keysym);
On 2013/09/17 15:05:10, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/23622035/diff/1/ui/aura/test/ui_controls_fact...
ui/aura/test/ui_controls_factory_aurax11.cc:242: keysym);
On 2013/09/17 15:05:10, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/23622035/diff/1/ui/base/x/events_x.cc
File ui/base/x/events_x.cc (right):

https://codereview.chromium.org/23622035/diff/1/ui/base/x/events_x.cc#newcode265
ui/base/x/events_x.cc:265: "noop", False);
On 2013/09/17 15:05:10, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/23622035/diff/1/ui/views/widget/desktop_aura/...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc (right):

https://codereview.chromium.org/23622035/diff/1/ui/views/widget/desktop_aura/...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:242:
source_window_, PropertyChangeMask);
On 2013/09/17 15:05:10, oshima wrote:
> ditto

Done.

[sadrul, 2013-09-17 16:44:12]

Committed patchset #2 manually as r223621 (presubmit successful).