Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2362203002: Minor fixes in the objects printer. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Minor fixes in the objects printer. Committed: https://crrev.com/9f0fe658538c67df524227edf7dba977ee93da63 Cr-Commit-Position: refs/heads/master@{#39669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -20 lines) Patch
M src/objects-printer.cc View 6 chunks +11 lines, -19 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-09-23 13:13:25 UTC) #7
Toon Verwaest
lgtm
4 years, 2 months ago (2016-09-23 13:51:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362203002/1
4 years, 2 months ago (2016-09-23 14:10:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-23 14:25:51 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 14:26:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f0fe658538c67df524227edf7dba977ee93da63
Cr-Commit-Position: refs/heads/master@{#39669}

Powered by Google App Engine
This is Rietveld 408576698