Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 23622029: Every place where AllocationMemento is initialized with an (Closed)

Created:
7 years, 3 months ago by mvstanton
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Every place where AllocationMemento is initialized with an AllocationSite is now checked to be sure a valid Site goes in. This is temporary code to diagnose chromium bug 284577. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M src/heap.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Michael, here is the CL that checks each location where we SET an AllocationSite ...
7 years, 3 months ago (2013-09-12 15:01:33 UTC) #1
Michael Starzinger
LGTM.
7 years, 3 months ago (2013-09-12 17:09:46 UTC) #2
mvstanton
7 years, 3 months ago (2013-09-13 08:13:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16705 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698