Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 23622028: Snapshot i18n Javascript code (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Snapshot i18n Javascript code The previous attempt used Boolean instead of $Boolean. BUG=v8:2745 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2131 lines, -2549 lines) Patch
M src/api.cc View 3 chunks +0 lines, -23 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +0 lines, -13 lines 0 comments Download
D src/extensions/i18n/break-iterator.js View 1 chunk +0 lines, -190 lines 0 comments Download
D src/extensions/i18n/collator.js View 1 chunk +0 lines, -209 lines 0 comments Download
D src/extensions/i18n/date-format.js View 1 chunk +0 lines, -474 lines 0 comments Download
D src/extensions/i18n/footer.js View 1 chunk +0 lines, -40 lines 0 comments Download
D src/extensions/i18n/globals.js View 1 chunk +0 lines, -168 lines 0 comments Download
D src/extensions/i18n/header.js View 1 chunk +0 lines, -41 lines 0 comments Download
D src/extensions/i18n/i18n-extension.h View 1 chunk +0 lines, -48 lines 0 comments Download
D src/extensions/i18n/i18n-extension.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D src/extensions/i18n/i18n-utils.js View 1 chunk +0 lines, -536 lines 0 comments Download
D src/extensions/i18n/locale.js View 1 chunk +0 lines, -190 lines 0 comments Download
D src/extensions/i18n/number-format.js View 1 chunk +0 lines, -289 lines 0 comments Download
D src/extensions/i18n/overrides.js View 1 chunk +0 lines, -220 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
A src/i18n.js View 1 chunk +2116 lines, -0 lines 0 comments Download
M src/mksnapshot.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/natives.h View 2 chunks +1 line, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 7 chunks +11 lines, -44 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-12 12:22:59 UTC) #1
Michael Starzinger
LGTM.
7 years, 3 months ago (2013-09-12 12:38:23 UTC) #2
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-12 13:51:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16687 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698