Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issue 23622022: Revert 221930 "[OSX] Turn on canvas_skia for OSX" (Closed)

Created:
7 years, 3 months ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 3 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221930 "[OSX] Turn on canvas_skia for OSX" > [OSX] Turn on canvas_skia for OSX > > BUG=151935 > > Review URL: https://chromiumcodereview.appspot.com/23456020 This broke mac compile: FAILED: clang++ -MMD -MF obj/ui/gfx/ui_unittests.canvas_unittest_mac.o.d -DANGLE_DX11 -DWTF_VECTOR_INITIAL_SIZE=4 -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DSKIA_DLL -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DU_USING_ICU_NAMESPACE=0 -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -I../.. -I../../third_party/skia/src/core -I../../skia/config -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/skia/include/utils/mac -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libpng -I../../third_party/zlib -Igen/ui/app_locale_settings -Igen/ui/ui_strings -Igen/ui/ui_resources -isysroot /Developer/SDKs/MacOSX10.6.sdk -O0 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-c++11-narrowing -Wno-char-subscripts -Wno-unused-function -Wno-covered-switch-default -Wstring-conversion -Wno-deprecated-register -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing -fstack-protector-all -fobjc-call-cxx-cdtors -c ../../ui/gfx/canvas_unittest_mac.mm -o obj/ui/gfx/ui_unittests.canvas_unittest_mac.o ../../ui/gfx/canvas_unittest_mac.mm:12:10: fatal error: 'ui/base/range/range.h' file not found #include "ui/base/range/range.h" ^ 1 error generated. ninja: build stopped: subcommand failed. TBR=groby@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -81 lines) Patch
M trunk/src/build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + trunk/src/ui/gfx/canvas_mac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/ui/gfx/canvas_unittest_mac.mm View 1 chunk +0 lines, -80 lines 0 comments Download
M trunk/src/ui/ui.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/ui/ui_unittests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
cpu_(ooo_6.6-7.5)
7 years, 3 months ago (2013-09-07 23:48:41 UTC) #1
cpu_(ooo_6.6-7.5)
7 years, 3 months ago (2013-09-07 23:50:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r221934.

Powered by Google App Engine
This is Rietveld 408576698