Fixing the dynamic positioning (move with anchor) for the app launcher

ui/views/bubble/bubble_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_
 
 #include "base/gtest_prod_util.h"
 #include "ui/base/animation/animation_delegate.h"
 #include "ui/views/bubble/bubble_border.h"
@@ skipping 126 matching lines @@
   virtual void OnNativeThemeChanged(const ui::NativeTheme* theme) OVERRIDE;
 
   // ui::AnimationDelegate overrides:
   virtual void AnimationEnded(const ui::Animation* animation) OVERRIDE;
   virtual void AnimationProgressed(const ui::Animation* animation) OVERRIDE;
 
   // Perform view initialization on the contents for bubble sizing.
   virtual void Init();
 
   // Set the anchor view or rect; set these before CreateBubble or Show.
+  // If an |anchor_view| is given the |anchor_rect| will be ignored, but an
+  // |anchor_offset| can be supplied to offset the final coordinates. This is
+  // especially needed when |move_with_anchor_| gets set.
   void set_anchor_view(View* anchor_view) { anchor_view_ = anchor_view; }
   void set_anchor_rect(const gfx::Rect& rect) { anchor_rect_ = rect; }
+  void set_anchor_offset(const gfx::Point& offset) {anchor_offset_ = offset; }

[xiyuan, 2013/09/06 04:34:53]

nit: the new fashion is to use Vector2d for offset.

[Mr4D (OOO till 08-26), 2013/09/06 17:57:31]

Done.

 
   // Resize and potentially move the bubble to fit the content's preferred size.
   void SizeToContents();
 
   BubbleFrameView* GetBubbleFrameView() const;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(BubbleDelegateTest, CreateDelegate);
   FRIEND_TEST_ALL_PREFIXES(BubbleDelegateTest, NonClientHitTest);
 
@@ skipping 15 matching lines @@
   bool close_on_esc_;
   bool close_on_deactivate_;
 
   // The view and widget to which this bubble is anchored.
   View* anchor_view_;
   Widget* anchor_widget_;
 
   // The anchor rect used in the absence of an anchor view.
   gfx::Rect anchor_rect_;
 
+  // An anchor offset which will get added to the |anchor_view_|'s location.
+  gfx::Point anchor_offset_;
+
   // If true, the bubble will re-anchor (and may resize) with |anchor_widget_|.
   bool move_with_anchor_;
 
   // The arrow's location on the bubble.
   BubbleBorder::Arrow arrow_;
 
   // Bubble border shadow to use.
   BubbleBorder::Shadow shadow_;
 
   // The background color of the bubble; and flag for when it's explicitly set.
@@ skipping 25 matching lines @@
 
   // Parent native window of the bubble.
   gfx::NativeView parent_window_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleDelegateView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_DELEGATE_H_