Fixing the dynamic positioning (move with anchor) for the app launcher

ui/app_list/views/app_list_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_APP_LIST_VIEWS_APP_LIST_VIEW_H_
 #define UI_APP_LIST_VIEWS_APP_LIST_VIEW_H_
 
 #include "base/callback_forward.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
@@ skipping 22 matching lines @@
   class Observer {
   public:
     virtual void OnActivationChanged(views::Widget* widget, bool active) = 0;
   };
 
   // Takes ownership of |delegate|.
   explicit AppListView(AppListViewDelegate* delegate);
   virtual ~AppListView();
 
   // Initializes the widget.
+  // If an |anchor| is provided, the |anchor_point| is a local offset, otherwise
+  // it is the anchor point in screen coordinates.
   void InitAsBubble(gfx::NativeView parent,
                     PaginationModel* pagination_model,
                     views::View* anchor,
                     const gfx::Point& anchor_point,

[James Cook, 2013/09/05 20:05:17]

I don't like having a parameter that can be in two different coordinate systems.
Either add an explicit extra parameter for anchor_offset or break into two
different Init methods.

[Mr4D (OOO till 08-26), 2013/09/05 20:52:00]

I did like none of the three possibilities. Okay - added another function. That
way the use case of the anchor gets at least much clearer!

                     views::BubbleBorder::Arrow arrow,
                     bool border_accepts_events);
 
   void SetBubbleArrow(views::BubbleBorder::Arrow arrow);
 
   void SetAnchorPoint(const gfx::Point& anchor_point);
 
   // If |drag_and_drop_host| is not NULL it will be called upon drag and drop
   // operations outside the application list. This has to be called after
   // InitAsBubble was called since the app list object needs to exist so that
@@ skipping 62 matching lines @@
   SigninView* signin_view_;
 
   ObserverList<Observer> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(AppListView);
 };
 
 }  // namespace app_list
 
 #endif  // UI_APP_LIST_VIEWS_APP_LIST_VIEW_H_