Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: src/objects.cc

Issue 23622016: limit InitialMaxFastElement by MaxRegularSpaceAllocationSize (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2130 matching lines...) Expand 10 before | Expand all | Expand 10 after
2141 isolate->observers_deliver_changes(), 2141 isolate->observers_deliver_changes(),
2142 isolate->factory()->undefined_value(), 2142 isolate->factory()->undefined_value(),
2143 0, 2143 0,
2144 NULL, 2144 NULL,
2145 &threw); 2145 &threw);
2146 ASSERT(!threw); 2146 ASSERT(!threw);
2147 isolate->set_observer_delivery_pending(false); 2147 isolate->set_observer_delivery_pending(false);
2148 } 2148 }
2149 2149
2150 2150
2151 int JSObject::InitialMaxFastElementArray(Heap* heap) {
2152 int max_array_base_size = JSArray::kSize + AllocationMemento::kSize +
2153 FixedArray::kHeaderSize;
2154 int size_limit = heap->MaxRegularSpaceAllocationSize() - max_array_base_size;
2155 int element_limit = size_limit / kPointerSize + 1;
2156 return Min(kInitialMaxFastElementArray, element_limit);
2157 }
2158
2159
2151 MaybeObject* JSObject::SetPropertyPostInterceptor( 2160 MaybeObject* JSObject::SetPropertyPostInterceptor(
2152 Name* name, 2161 Name* name,
2153 Object* value, 2162 Object* value,
2154 PropertyAttributes attributes, 2163 PropertyAttributes attributes,
2155 StrictModeFlag strict_mode, 2164 StrictModeFlag strict_mode,
2156 StoreMode mode) { 2165 StoreMode mode) {
2157 // Check local property, ignore interceptor. 2166 // Check local property, ignore interceptor.
2158 LookupResult result(GetIsolate()); 2167 LookupResult result(GetIsolate());
2159 LocalLookupRealNamedProperty(name, &result); 2168 LocalLookupRealNamedProperty(name, &result);
2160 if (!result.IsFound()) map()->LookupTransition(this, name, &result); 2169 if (!result.IsFound()) map()->LookupTransition(this, name, &result);
(...skipping 13819 matching lines...) Expand 10 before | Expand all | Expand 10 after
15980 #define ERROR_MESSAGES_TEXTS(C, T) T, 15989 #define ERROR_MESSAGES_TEXTS(C, T) T,
15981 static const char* error_messages_[] = { 15990 static const char* error_messages_[] = {
15982 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 15991 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
15983 }; 15992 };
15984 #undef ERROR_MESSAGES_TEXTS 15993 #undef ERROR_MESSAGES_TEXTS
15985 return error_messages_[reason]; 15994 return error_messages_[reason];
15986 } 15995 }
15987 15996
15988 15997
15989 } } // namespace v8::internal 15998 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698