components/autofill/content/DEPS - Issue 23622013: Move password_form_conversion_utils out of //content into //autofill.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/content/DEPS

Issue 23622013: Move password_form_conversion_utils out of //content into //autofill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@password_form_includes_removal

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+content/public/common",	2 "+content/public/common",

3 # Allow inclusion of WebKit API files.	3 # Allow inclusion of WebKit API files.

4 "+third_party/WebKit/public/platform",	4 "+third_party/WebKit/public/platform",

5 "+third_party/WebKit/public/web",	5 "+third_party/WebKit/public/web",

6 ]	6 ]

	7

	8 specific_include_rules = {

	9 '._[a-z]test\.cc': [
	Ilya Sherman 2013/08/30 21:55:47 Could you narrow this rule to allow only the speci Could you narrow this rule to allow only the specific tests that currently have this dependency, and annotate with a TODO + bug to remove this? blundell 2013/09/02 10:52:56 This is the DEPS file for //components/autofill/co This is the DEPS file for //components/autofill/content, so there is no problem with its test code using //content/public/test unless there is something I'm missing. On 2013/08/30 21:55:47, Ilya Sherman wrote: Show quoted text > Could you narrow this rule to allow only the specific tests that currently have > this dependency, and annotate with a TODO + bug to remove this? Ilya Sherman 2013/09/03 22:39:18 Ah, I mistook this for a temporary exception. Nev Ah, I mistook this for a temporary exception. Never mind :) On 2013/09/02 10:52:56, blundell wrote: Show quoted text > This is the DEPS file for //components/autofill/content, so there is no problem > with its test code using //content/public/test unless there is something I'm > missing. > > On 2013/08/30 21:55:47, Ilya Sherman wrote: > > Could you narrow this rule to allow only the specific tests that currently > have > > this dependency, and annotate with a TODO + bug to remove this? >
	10 "+content/public/test",

	11 ],

	12 }

OLD	NEW

« chrome/chrome_tests.gypi ('K') | « components/autofill.gypi ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »