Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 23622012: Integrate the LocalPredictor with the Prerender Service. (Closed)

Created:
7 years, 3 months ago by tburkard
Modified:
7 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org
Visibility:
Public.

Description

Integrate the LocalPredictor with the Prerender Service. R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220674

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 6

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+534 lines, -62 lines) Patch
M chrome/browser/prerender/prerender_field_trial.h View 3 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_field_trial.cc View 1 2 3 4 5 6 7 7 chunks +84 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_local_predictor.h View 1 2 3 4 5 6 7 6 chunks +47 lines, -11 lines 0 comments Download
M chrome/browser/prerender/prerender_local_predictor.cc View 1 2 3 4 5 6 7 18 chunks +385 lines, -46 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tburkard
7 years, 3 months ago (2013-08-29 23:33:41 UTC) #1
tburkard
7 years, 3 months ago (2013-08-30 01:17:25 UTC) #2
tburkard
7 years, 3 months ago (2013-08-30 17:22:19 UTC) #3
tburkard
7 years, 3 months ago (2013-08-30 20:19:58 UTC) #4
jam
https://codereview.chromium.org/23622012/diff/113001/chrome/browser/prerender/prerender_local_predictor.cc File chrome/browser/prerender/prerender_local_predictor.cc (right): https://codereview.chromium.org/23622012/diff/113001/chrome/browser/prerender/prerender_local_predictor.cc#newcode772 chrome/browser/prerender/prerender_local_predictor.cc:772: for (int i = 0; i < static_cast<int>(list->GetSize()); i++) ...
7 years, 3 months ago (2013-08-30 20:34:30 UTC) #5
tburkard
https://codereview.chromium.org/23622012/diff/113001/chrome/browser/prerender/prerender_local_predictor.cc File chrome/browser/prerender/prerender_local_predictor.cc (right): https://codereview.chromium.org/23622012/diff/113001/chrome/browser/prerender/prerender_local_predictor.cc#newcode772 chrome/browser/prerender/prerender_local_predictor.cc:772: for (int i = 0; i < static_cast<int>(list->GetSize()); i++) ...
7 years, 3 months ago (2013-08-30 20:59:01 UTC) #6
jam
lgtm
7 years, 3 months ago (2013-08-30 21:00:37 UTC) #7
tburkard
7 years, 3 months ago (2013-08-30 22:09:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #9 manually as r220674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698