Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 23622005: ninja/mac: Allow more than one ld process at a time, based on available RAM. (Closed)

Created:
7 years, 3 months ago by Nico
Modified:
7 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com, scottmg
Visibility:
Public.

Description

ninja/mac: Allow more than one ld process at a time, based on available RAM. Allow one concurrent ld process for every 4 GB of ram. This matches what ninja/windows does. R=mark@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1706

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M pylib/gyp/generator/ninja.py View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
(iannucci: linking now uses pools on win, linux, mac)
7 years, 3 months ago (2013-08-27 23:37:26 UTC) #1
iannucci
On 2013/08/27 23:37:26, Nico wrote: > (iannucci: linking now uses pools on win, linux, mac) ...
7 years, 3 months ago (2013-08-28 01:18:44 UTC) #2
Mark Mentovai
LGTM
7 years, 3 months ago (2013-08-28 01:23:12 UTC) #3
Nico
7 years, 3 months ago (2013-08-28 18:29:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r1706 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698