Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2362183002: Prune CreateVisiblePositionDeprecated from VisibleSelection::visibleBase/Extent (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune CreateVisiblePositionDeprecated from VisibleSelection::visibleBase/Extent Caller of these two functions have already ensured clean layout, so this patch safely prunes CreateVisiblePositionDeprecated from them. BUG=647219 Committed: https://crrev.com/0db24bb3a3073a9296b05d5bfc592727db2f94c4 Cr-Commit-Position: refs/heads/master@{#420866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-23 08:04:08 UTC) #4
yosin_UTC9
lgtm It seems win_chromium_rel_ng fails to link content_shell.exe
4 years, 2 months ago (2016-09-26 01:24:24 UTC) #15
Xiaocheng
On 2016/09/26 at 01:24:24, yosin wrote: > lgtm > > It seems win_chromium_rel_ng fails to ...
4 years, 2 months ago (2016-09-26 01:28:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362183002/1
4 years, 2 months ago (2016-09-26 02:04:40 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 02:11:03 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 02:14:13 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0db24bb3a3073a9296b05d5bfc592727db2f94c4
Cr-Commit-Position: refs/heads/master@{#420866}

Powered by Google App Engine
This is Rietveld 408576698