|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by Xiaocheng Modified:
4 years, 2 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrune CreateVisiblePositionDeprecated from VisibleSelection::visibleBase/Extent
Caller of these two functions have already ensured clean layout, so this
patch safely prunes CreateVisiblePositionDeprecated from them.
BUG=647219
Committed: https://crrev.com/0db24bb3a3073a9296b05d5bfc592727db2f94c4
Cr-Commit-Position: refs/heads/master@{#420866}
Patch Set 1 #
Messages
Total messages: 23 (17 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
xiaochengh@chromium.org changed reviewers: + yosin@chromium.org
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
The CQ bit was unchecked by xiaochengh@chromium.org
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm It seems win_chromium_rel_ng fails to link content_shell.exe
On 2016/09/26 at 01:24:24, yosin wrote: > lgtm > > It seems win_chromium_rel_ng fails to link content_shell.exe The bot is failing in so many ways... The only thing I'm sure about is that it can't be my fault :)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaochengh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Prune CreateVisiblePositionDeprecated from VisibleSelection::visibleBase/Extent Caller of these two functions have already ensured clean layout, so this patch safely prunes CreateVisiblePositionDeprecated from them. BUG=647219 ========== to ========== Prune CreateVisiblePositionDeprecated from VisibleSelection::visibleBase/Extent Caller of these two functions have already ensured clean layout, so this patch safely prunes CreateVisiblePositionDeprecated from them. BUG=647219 Committed: https://crrev.com/0db24bb3a3073a9296b05d5bfc592727db2f94c4 Cr-Commit-Position: refs/heads/master@{#420866} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0db24bb3a3073a9296b05d5bfc592727db2f94c4 Cr-Commit-Position: refs/heads/master@{#420866} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
