src/compiler/js-native-context-specialization.h - Issue 2362173003: [turbofan] Improve representation selection for Smi checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-native-context-specialization.h

Issue 2362173003: [turbofan] Improve representation selection for Smi checking. (Closed)

Patch Set: Address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-native-context-specialization.h

diff --git a/src/compiler/js-native-context-specialization.h b/src/compiler/js-native-context-specialization.h

index 8ba5b65418a2f75d43f452fad6f7783e4c080b4f..495a8e1c2307650325aa8a9d2d737ac7f89c1075 100644

--- a/src/compiler/js-native-context-specialization.h

+++ b/src/compiler/js-native-context-specialization.h

@@ -118,7 +118,7 @@ class JSNativeContextSpecialization final : public AdvancedReducer {

std::vector<Handle<Map>> const& maps);

// Construct an appropriate heap object check.

- Node* BuildCheckTaggedPointer(Node* receiver, Node* effect, Node* control);

+ Node* BuildCheckHeapObject(Node* receiver, Node* effect, Node* control);

// Adds stability dependencies on all prototypes of every class in

// {receiver_type} up to (and including) the {holder}.