src/compiler/effect-control-linearizer.h - Issue 2362173003: [turbofan] Improve representation selection for Smi checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/effect-control-linearizer.h

Issue 2362173003: [turbofan] Improve representation selection for Smi checking. (Closed)

Patch Set: Address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/effect-control-linearizer.h

diff --git a/src/compiler/effect-control-linearizer.h b/src/compiler/effect-control-linearizer.h

index 2322efc0a7f8ab014029a18b5dcb68bc7669e326..6461f03085c4eb9875e1c6bedf356a2e5e39b220 100644

--- a/src/compiler/effect-control-linearizer.h

+++ b/src/compiler/effect-control-linearizer.h

@@ -71,10 +71,8 @@ class EffectControlLinearizer {

Node* effect, Node* control);

ValueEffectControl LowerCheckIf(Node* node, Node* frame_state, Node* effect,

Node* control);

- ValueEffectControl LowerCheckTaggedPointer(Node* node, Node* frame_state,

- Node* effect, Node* control);

- ValueEffectControl LowerCheckTaggedSigned(Node* node, Node* frame_state,

- Node* effect, Node* control);

+ ValueEffectControl LowerCheckHeapObject(Node* node, Node* frame_state,

+ Node* effect, Node* control);

ValueEffectControl LowerCheckedInt32Add(Node* node, Node* frame_state,

Node* effect, Node* control);

ValueEffectControl LowerCheckedInt32Sub(Node* node, Node* frame_state,

@@ -89,8 +87,16 @@ class EffectControlLinearizer {

Node* effect, Node* control);

ValueEffectControl LowerCheckedInt32Mul(Node* node, Node* frame_state,

Node* effect, Node* control);

+ ValueEffectControl LowerCheckedInt32ToTaggedSigned(Node* node,

+ Node* frame_state,

+ Node* effect,

+ Node* control);

ValueEffectControl LowerCheckedUint32ToInt32(Node* node, Node* frame_state,

Node* effect, Node* control);

+ ValueEffectControl LowerCheckedUint32ToTaggedSigned(Node* node,

+ Node* frame_state,

+ Node* effect,

+ Node* control);

ValueEffectControl LowerCheckedFloat64ToInt32(Node* node, Node* frame_state,

Node* effect, Node* control);

ValueEffectControl LowerCheckedTaggedSignedToInt32(Node* node,

@@ -101,6 +107,10 @@ class EffectControlLinearizer {

Node* effect, Node* control);

ValueEffectControl LowerCheckedTaggedToFloat64(Node* node, Node* frame_state,

Node* effect, Node* control);

+ ValueEffectControl LowerCheckedTaggedToTaggedSigned(Node* node,

+ Node* frame_state,

+ Node* effect,

+ Node* control);

ValueEffectControl LowerChangeTaggedToFloat64(Node* node, Node* effect,

Node* control);

ValueEffectControl LowerTruncateTaggedToBit(Node* node, Node* effect,

« no previous file with comments | « src/compiler/code-generator.cc ('k') | src/compiler/effect-control-linearizer.cc » ('j') | no next file with comments »