[modules] Support star exports.

[modules] Support star exports.

R=adamk@chromium.org
BUG=v8:1569
Committed: https://crrev.com/61689598754856127a6ef1aa3952064f597e999e
Cr-Commit-Position: refs/heads/master@{#39700}

[neis, 2016-09-24 00:48:46]

please have a first look.

[adamk, 2016-09-24 01:00:38]

Description was changed from

==========
[modules] Support star exports.

R=adamk@chromium.org
BUG=
==========

to

==========
[modules] Support star exports.

R=adamk@chromium.org
BUG=v8:1569
==========

[adamk, 2016-09-24 01:01:00]

https://codereview.chromium.org/2362153003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2362153003/diff/1/src/objects.cc#newcode19694
src/objects.cc:19694: continue;  // Indirect export.
Please wrap with { } or move comment above :)

https://codereview.chromium.org/2362153003/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2362153003/diff/1/src/objects.h#newcode7987
src/objects.h:7987: // Helper for ResolveExport.
Please document the fact that you have to check the isolate for exceptions. I'm
still not loving this though.

https://codereview.chromium.org/2362153003/diff/1/test/mjsunit/modules-fail-8.js
File test/mjsunit/modules-fail-8.js (right):

https://codereview.chromium.org/2362153003/diff/1/test/mjsunit/modules-fail-8...
test/mjsunit/modules-fail-8.js:8: assertEquals(10, a);
Remove this assertEquals

[neis, 2016-09-24 01:17:45]

On 2016/09/24 01:01:00, adamk wrote:
> https://codereview.chromium.org/2362153003/diff/1/src/objects.cc
> File src/objects.cc (right):
> 
> https://codereview.chromium.org/2362153003/diff/1/src/objects.cc#newcode19694
> src/objects.cc:19694: continue;  // Indirect export.
> Please wrap with { } or move comment above :)
> 
> https://codereview.chromium.org/2362153003/diff/1/src/objects.h
> File src/objects.h (right):
> 
> https://codereview.chromium.org/2362153003/diff/1/src/objects.h#newcode7987
> src/objects.h:7987: // Helper for ResolveExport.
> Please document the fact that you have to check the isolate for exceptions.
I'm
> still not loving this though.
> 
>
https://codereview.chromium.org/2362153003/diff/1/test/mjsunit/modules-fail-8.js
> File test/mjsunit/modules-fail-8.js (right):
> 
>
https://codereview.chromium.org/2362153003/diff/1/test/mjsunit/modules-fail-8...
> test/mjsunit/modules-fail-8.js:8: assertEquals(10, a);
> Remove this assertEquals

All done

[adamk, 2016-09-24 01:19:06]

lgtm for now (hopefully we'll make the interface of ResolveExport better over
time).

[adamk, 2016-09-24 01:19:14]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-09-24 01:19:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 01:46:53]

Description was changed from

==========
[modules] Support star exports.

R=adamk@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Support star exports.

R=adamk@chromium.org
BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-09-24 01:46:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-24 01:47:09]

Description was changed from

==========
[modules] Support star exports.

R=adamk@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Support star exports.

R=adamk@chromium.org
BUG=v8:1569

Committed: https://crrev.com/61689598754856127a6ef1aa3952064f597e999e
Cr-Commit-Position: refs/heads/master@{#39700}
==========

[commit-bot: I haz the power, 2016-09-24 01:47:10]

Patchset 2 (id:??) landed as
https://crrev.com/61689598754856127a6ef1aa3952064f597e999e
Cr-Commit-Position: refs/heads/master@{#39700}