Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2362143002: [Android] Add experimental gtest xml result handling. (Closed)

Created:
4 years, 3 months ago by jbudorick
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add experimental gtest xml result handling. BUG=646677 Committed: https://crrev.com/5cea02e8af2873fd86864d8273084ab550be8284 Cr-Commit-Position: refs/heads/master@{#420639}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rnephew comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -16 lines) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 4 chunks +36 lines, -0 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 1 5 chunks +43 lines, -16 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jbudorick
4 years, 3 months ago (2016-09-23 04:18:02 UTC) #2
rnephew (Reviews Here)
lgtm with one question. https://codereview.chromium.org/2362143002/diff/1/build/android/pylib/local/device/local_device_gtest_run.py File build/android/pylib/local/device/local_device_gtest_run.py (right): https://codereview.chromium.org/2362143002/diff/1/build/android/pylib/local/device/local_device_gtest_run.py#newcode357 build/android/pylib/local/device/local_device_gtest_run.py:357: flags += ' --gtest_output=xml:%s' % ...
4 years, 3 months ago (2016-09-23 14:10:52 UTC) #3
jbudorick
https://codereview.chromium.org/2362143002/diff/1/build/android/pylib/local/device/local_device_gtest_run.py File build/android/pylib/local/device/local_device_gtest_run.py (right): https://codereview.chromium.org/2362143002/diff/1/build/android/pylib/local/device/local_device_gtest_run.py#newcode357 build/android/pylib/local/device/local_device_gtest_run.py:357: flags += ' --gtest_output=xml:%s' % device_tmp_results_file.name On 2016/09/23 14:10:51, ...
4 years, 3 months ago (2016-09-23 15:23:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362143002/20001
4 years, 3 months ago (2016-09-23 15:23:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/298653)
4 years, 3 months ago (2016-09-23 15:35:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362143002/20001
4 years, 3 months ago (2016-09-23 16:16:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 17:06:37 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 17:09:08 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5cea02e8af2873fd86864d8273084ab550be8284
Cr-Commit-Position: refs/heads/master@{#420639}

Powered by Google App Engine
This is Rietveld 408576698