[swarming/api] Add text in to indicate whether a shard is failing (RELAND)

[swarming/api] Add text in to indicate whether a shard is failing (RELAND)

This includes the fix to check condition of shard's exit_code by comparing against '0' instead of 0 (patchset 2)

BUG=chromium:639321
Committed: https://chromium.googlesource.com/chromium/tools/build/+/8de08d6f8632eb8e49b8ba6a4e19ad4b465df16c

[nednguyen, 2016-09-23 01:00:58]

nednguyen@google.com changed reviewers:
+ kbr@chromium.org, maruel@google.com, vadim@chromium.org

[nednguyen, 2016-09-23 01:04:19]

On 2016/09/23 01:00:58, nednguyen wrote:

For double check, here is an example summary.json (from
https://chromium-swarm.appspot.com/user/task/316d493b591b3c10)

{
  "shards": [
    {
      "bot_dimensions": [
        {
          "key": "cores",
          "value": [
            "8"
          ]
        },
        {
          "key": "cpu",
          "value": [
            "x86",
            "x86-64"
          ]
        },
        {
          "key": "gpu",
          "value": [
            "none"
          ]
        },
        {
          "key": "id",
          "value": [
            "vm22-m4"
          ]
        },
        {
          "key": "machine_type",
          "value": [
            "n1-highcpu-8"
          ]
        },
        {
          "key": "os",
          "value": [
            "Windows",
            "Windows-7-SP1"
          ]
        },
        {
          "key": "pool",
          "value": [
            "Chrome"
          ]
        }
      ],
      "bot_id": "vm22-m4",
      "bot_version": "02aa9441fa1d8aa587edf4bd4660d8817d4f2f4d",
      "completed_ts": "2016-09-23T00:38:03.283050",
      "costs_usd": [
        0.029975528036678915
      ],
      "created_ts": "2016-09-23T00:35:13.354630",
      "duration": 146.7590000629425,
      "exit_code": "0",
      "failure": false,
      "internal_failure": false,
      "modified_ts": "2016-09-23T00:38:03.283050",
      "name": "telemetry_perf_unittests (with
patch)/Windows-7-SP1/0b8386ece4/win_chromium_x64_rel_ng/284618:0:12",
....
}

[nednguyen, 2016-09-23 01:04:24]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 01:04:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 01:04:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 01:04:31]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[nednguyen(REVIEW IN OTHER ACC), 2016-09-23 01:18:29]

Description was changed from

==========
[swarming api] Update the check condition of shard's exit_code by comparing with
'0' instead of 0

BUG=chromium:639321
==========

to

==========
[swarming api] Update the check condition of shard's exit_code by comparing
against '0' instead of 0

BUG=chromium:639321
==========

[nednguyen, 2016-09-23 01:28:06]

Description was changed from

==========
[swarming api] Update the check condition of shard's exit_code by comparing
against '0' instead of 0

BUG=chromium:639321
==========

to

==========
[swarming/api] Add text in to indicate whether a shard is failing (RELAND)

This includes the fix to check condition of shard's exit_code by comparing
against '0' instead of 0 (patchset 3)

BUG=chromium:639321
==========

[nednguyen, 2016-09-23 01:29:06]

Patchset #1 (id:1) has been deleted

[nednguyen, 2016-09-23 01:30:56]

Description was changed from

==========
[swarming/api] Add text in to indicate whether a shard is failing (RELAND)

This includes the fix to check condition of shard's exit_code by comparing
against '0' instead of 0 (patchset 3)

BUG=chromium:639321
==========

to

==========
[swarming/api] Add text in to indicate whether a shard is failing (RELAND)

This includes the fix to check condition of shard's exit_code by comparing
against '0' instead of 0 (patchset 2)

BUG=chromium:639321
==========

[Ken Russell (switch to Gerrit), 2016-09-23 18:17:00]

LGTM, but I'm not an OWNER.

[nednguyen, 2016-09-23 18:18:50]

Ping vadim

[nednguyen, 2016-09-26 18:17:08]

On 2016/09/23 18:18:50, nednguyen wrote:
> Ping vadim

Ping infra folks

[Ken Russell (switch to Gerrit), 2016-09-26 21:15:24]

kbr@chromium.org changed reviewers:
+ vadimsh@chromium.org
- vadim@chromium.org

[Ken Russell (switch to Gerrit), 2016-09-26 21:15:24]

Ned: wrong Vadim. It's vadimsh@ (now CC'd)

[Vadim Sh., 2016-09-26 21:17:46]

lgtm

[nednguyen, 2016-09-26 21:19:55]

On 2016/09/26 21:17:46, Vadim Sh. wrote:
> lgtm

Ooopps, thank Ken!

[nednguyen, 2016-09-26 21:19:59]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-09-26 21:20:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 21:27:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 21:27:32]

Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3181337d0cdfb110)

[Ken Russell (switch to Gerrit), 2016-09-26 21:31:58]

On 2016/09/26 21:27:32, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   Build Presubmit on luci.infra.try (JOB_FAILED,
> https://luci-milo.appspot.com/swarming/task/3181337d0cdfb110)

Need to retrain and/or add more recipe simulation tests.

[nednguyen, 2016-09-26 21:33:11]

On 2016/09/26 21:31:58, Ken Russell wrote:
> On 2016/09/26 21:27:32, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   Build Presubmit on luci.infra.try (JOB_FAILED,
> > https://luci-milo.appspot.com/swarming/task/3181337d0cdfb110)
> 
> Need to retrain and/or add more recipe simulation tests.

Done. Thanks

[nednguyen, 2016-09-26 21:33:16]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-09-26 21:33:16]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2362133003/#ps60001
(title: "Rebase [retrain]")

[commit-bot: I haz the power, 2016-09-26 21:33:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 21:37:22]

Description was changed from

==========
[swarming/api] Add text in to indicate whether a shard is failing (RELAND)

This includes the fix to check condition of shard's exit_code by comparing
against '0' instead of 0 (patchset 2)

BUG=chromium:639321
==========

to

==========
[swarming/api] Add text in to indicate whether a shard is failing (RELAND)

This includes the fix to check condition of shard's exit_code by comparing
against '0' instead of 0 (patchset 2)

BUG=chromium:639321

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/8de08d6f8632eb8e49b8...
==========

[commit-bot: I haz the power, 2016-09-26 21:37:24]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/8de08d6f8632eb8e49b8...