Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 236213002: Move most of extension_file_util.cc into extensions/common/file_util.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase (file-util) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/unpacked_installer.cc
diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc
index dec1deacfb4dd92f5c05dbd04d3c6a29b42c0623..1a41314a5c92d070d3baec247d5a7d8590a3c9dc 100644
--- a/chrome/browser/extensions/unpacked_installer.cc
+++ b/chrome/browser/extensions/unpacked_installer.cc
@@ -18,12 +18,12 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/api/plugins/plugins_handler.h"
-#include "chrome/common/extensions/extension_file_util.h"
#include "content/public/browser/browser_thread.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_l10n_util.h"
+#include "extensions/common/file_util.h"
#include "extensions/common/id_util.h"
#include "extensions/common/manifest.h"
#include "sync/api/string_ordinal.h"
@@ -149,8 +149,9 @@ bool UnpackedInstaller::LoadFromCommandLine(const base::FilePath& path_in,
}
std::string error;
- installer_.set_extension(extension_file_util::LoadExtension(
- extension_path_, Manifest::COMMAND_LINE, GetFlags(), &error).get());
+ installer_.set_extension(
+ file_util::LoadExtension(
+ extension_path_, Manifest::COMMAND_LINE, GetFlags(), &error).get());
if (!installer_.extension().get() ||
!extension_l10n_util::ValidateExtensionLocales(
@@ -236,8 +237,7 @@ void UnpackedInstaller::GetAbsolutePath() {
extension_path_ = base::MakeAbsoluteFilePath(extension_path_);
std::string error;
- if (!extension_file_util::CheckForIllegalFilenames(extension_path_,
- &error)) {
+ if (!file_util::CheckForIllegalFilenames(extension_path_, &error)) {
BrowserThread::PostTask(
BrowserThread::UI,
FROM_HERE,
@@ -269,8 +269,9 @@ void UnpackedInstaller::LoadWithFileAccess(int flags) {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
std::string error;
- installer_.set_extension(extension_file_util::LoadExtension(
- extension_path_, Manifest::UNPACKED, flags, &error).get());
+ installer_.set_extension(
+ file_util::LoadExtension(
+ extension_path_, Manifest::UNPACKED, flags, &error).get());
if (!installer_.extension().get() ||
!extension_l10n_util::ValidateExtensionLocales(

Powered by Google App Engine
This is Rietveld 408576698