chrome/browser/extensions/extension_garbage_collector.cc - Issue 236213002: Move most of extension_file_util.cc into extensions/common/file_util.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_garbage_collector.cc

Issue 236213002: Move most of extension_file_util.cc into extensions/common/file_util.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase (file-util) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_creator.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | extensions/common/file_util_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_garbage_collector.cc

diff --git a/chrome/browser/extensions/extension_garbage_collector.cc b/chrome/browser/extensions/extension_garbage_collector.cc

index 78ddd1398c54204fddf56128957715abaeb752a2..ab899c3480c77b2d62c66a69afb008ee55136060 100644

--- a/chrome/browser/extensions/extension_garbage_collector.cc

+++ b/chrome/browser/extensions/extension_garbage_collector.cc

@@ -17,7 +17,6 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_util.h"

#include "chrome/browser/extensions/pending_extension_manager.h"

-#include "chrome/common/extensions/extension_file_util.h"

#include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/browser_thread.h"

@@ -26,6 +25,7 @@

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

#include "extensions/common/extension.h"

+#include "extensions/common/file_util.h"

namespace extensions {

@@ -46,7 +46,7 @@ void CheckExtensionDirectory(const base::FilePath& path,

base::FilePath basename = path.BaseName();

// Clean up temporary files left if Chrome crashed or quit in the middle

// of an extension install.

- if (basename.value() == extension_file_util::kTempDirectoryName) {

+ if (basename.value() == file_util::kTempDirectoryName) {

if (clean_temp_dir)

base::DeleteFile(path, true); // Recursive.

return;