chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc - Issue 236213002: Move most of extension_file_util.cc into extensions/common/file_util.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

Issue 236213002: Move most of extension_file_util.cc into extensions/common/file_util.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: zip (file-util) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« apps/shell/DEPS ('K') | « chrome/browser/extensions/user_script_listener_unittest.cc ('k') | chrome/common/extensions/extension_file_util.h » ('j') | chrome/common/extensions/extension_file_util_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

diff --git a/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc b/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

index 29d27f86765abafe20219f00db462fc8e4e44e3e..a9d9ed81ca291b5adc622a7c10e3f3d76bb70c50 100644

--- a/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

+++ b/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

@@ -12,9 +12,9 @@

#include "base/files/scoped_temp_dir.h"

#include "base/values.h"

#include "chrome/common/chrome_version_info.h"

-#include "chrome/common/extensions/extension_file_util.h"

#include "chrome/common/extensions/features/feature_channel.h"

#include "extensions/common/extension.h"

+#include "extensions/common/file_util.h"

#include "extensions/common/manifest.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -60,8 +60,7 @@ class StorageSchemaManifestHandlerTest : public testing::Test {

return testing::AssertionFailure() << "Failed to create test extension";

std::string error;

std::vector<InstallWarning> warnings;

- if (extension_file_util::ValidateExtension(

- extension.get(), &error, &warnings))

+ if (file_util::ValidateExtension(extension.get(), &error, &warnings))

return testing::AssertionSuccess();

return testing::AssertionFailure() << error;

}