Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: chrome/browser/extensions/unpacked_installer.h

Issue 236213002: Move most of extension_file_util.cc into extensions/common/file_util.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase (file-util) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_UNPACKED_INSTALLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_UNPACKED_INSTALLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_UNPACKED_INSTALLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_UNPACKED_INSTALLER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 78
79 // Verifies if loading unpacked extensions is allowed. 79 // Verifies if loading unpacked extensions is allowed.
80 bool IsLoadingUnpackedAllowed() const; 80 bool IsLoadingUnpackedAllowed() const;
81 81
82 // We change the input extension path to an absolute path, on the file thread. 82 // We change the input extension path to an absolute path, on the file thread.
83 // Then we need to check the file access preference, which needs 83 // Then we need to check the file access preference, which needs
84 // to happen back on the UI thread, so it posts CheckExtensionFileAccess on 84 // to happen back on the UI thread, so it posts CheckExtensionFileAccess on
85 // the UI thread. In turn, once that gets the pref, it goes back to the 85 // the UI thread. In turn, once that gets the pref, it goes back to the
86 // file thread with LoadWithFileAccess. 86 // file thread with LoadWithFileAccess.
87 // TODO(yoz): It would be nice to remove this ping-pong, but we need to know 87 // TODO(yoz): It would be nice to remove this ping-pong, but we need to know
88 // what file access flags to pass to extension_file_util::LoadExtension. 88 // what file access flags to pass to file_util::LoadExtension.
89 void GetAbsolutePath(); 89 void GetAbsolutePath();
90 void CheckExtensionFileAccess(); 90 void CheckExtensionFileAccess();
91 void LoadWithFileAccess(int flags); 91 void LoadWithFileAccess(int flags);
92 92
93 // Notify the frontend that an attempt to retry will not be necessary. 93 // Notify the frontend that an attempt to retry will not be necessary.
94 void UnregisterLoadRetryListener(); 94 void UnregisterLoadRetryListener();
95 95
96 // Notify the frontend that there was an error loading an extension. 96 // Notify the frontend that there was an error loading an extension.
97 void ReportExtensionLoadError(const std::string& error); 97 void ReportExtensionLoadError(const std::string& error);
98 98
(...skipping 20 matching lines...) Expand all
119 119
120 // Gives access to common methods and data of an extension installer. 120 // Gives access to common methods and data of an extension installer.
121 ExtensionInstaller installer_; 121 ExtensionInstaller installer_;
122 122
123 DISALLOW_COPY_AND_ASSIGN(UnpackedInstaller); 123 DISALLOW_COPY_AND_ASSIGN(UnpackedInstaller);
124 }; 124 };
125 125
126 } // namespace extensions 126 } // namespace extensions
127 127
128 #endif // CHROME_BROWSER_EXTENSIONS_UNPACKED_INSTALLER_H_ 128 #endif // CHROME_BROWSER_EXTENSIONS_UNPACKED_INSTALLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698