Move most of extension_file_util.cc into extensions/common/file_util.cc

Move most of extension_file_util.cc into extensions/common/file_util.cc

This allows file_util::LoadExtension to be used from app_shell.

Also added a trivial unit test for the one function remaining in
extension_file_util.

BUG=362752
TEST=unit_tests, added GetBrowserImagePaths
TBR=stevenjb@chromium.org for mechanical header file renames touching c/b/chromeos

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263889

[James Cook, 2014-04-12 00:03:22]

yoz, PTAL

rockot, just FYI about the DEPS cleanup

One more dependency down.

https://codereview.chromium.org/236213002/diff/20001/apps/shell/DEPS
File apps/shell/DEPS (left):

https://codereview.chromium.org/236213002/diff/20001/apps/shell/DEPS#oldcode20
apps/shell/DEPS:20:
"!chrome/common/extensions/api/sockets/sockets_manifest_handler.h",
The rest of these were unused DEPS so I cleaned them out.

https://codereview.chromium.org/236213002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/extension_file_util_unittest.cc (right):

https://codereview.chromium.org/236213002/diff/20001/chrome/common/extensions...
chrome/common/extensions/extension_file_util_unittest.cc:21:
TEST_F(ExtensionFileUtilTest, GetBrowserImagePaths) {
I added this trivial unit test mostly to give this file a reason to continue to
exist. :-)

https://codereview.chromium.org/236213002/diff/20001/extensions/common/file_u...
File extensions/common/file_util.cc (right):

https://codereview.chromium.org/236213002/diff/20001/extensions/common/file_u...
extensions/common/file_util.cc:56: const base::FilePath::CharType
kTempDirectoryName[] = FILE_PATH_LITERAL("Temp");
This code is also unchanged except for moving it into namespace extensions and
running git cl format.

https://codereview.chromium.org/236213002/diff/20001/extensions/common/file_u...
File extensions/common/file_util.h (right):

https://codereview.chromium.org/236213002/diff/20001/extensions/common/file_u...
extensions/common/file_util.h:31: extern const base::FilePath::CharType
kTempDirectoryName[];
This code is unchanged except for putting it into namespace extensions.

https://codereview.chromium.org/236213002/diff/20001/extensions/common/file_u...
File extensions/common/file_util_unittest.cc (right):

https://codereview.chromium.org/236213002/diff/20001/extensions/common/file_u...
extensions/common/file_util_unittest.cc:29: scoped_refptr<Extension>
LoadExtensionManifest(
These were file-level statics before; I moved them into namespace {}.  Otherwise
the code in this file is unchanged.

[Ken Rockot(use gerrit already), 2014-04-12 00:14:28]

https://codereview.chromium.org/236213002/diff/20001/apps/shell/DEPS
File apps/shell/DEPS (left):

https://codereview.chromium.org/236213002/diff/20001/apps/shell/DEPS#oldcode20
apps/shell/DEPS:20:
"!chrome/common/extensions/api/sockets/sockets_manifest_handler.h",
On 2014/04/12 00:03:22, James Cook wrote:
> The rest of these were unused DEPS so I cleaned them out.

YEEEEEEEEAH

[Yoyo Zhou, 2014-04-14 21:32:55]

LGTM

[James Cook, 2014-04-14 22:38:24]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-04-14 22:39:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/236213002/40001

[commit-bot: I haz the power, 2014-04-14 23:52:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-14 23:52:44]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[James Cook, 2014-04-15 00:11:02]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-04-15 00:11:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/236213002/40001

[commit-bot: I haz the power, 2014-04-15 08:03:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-15 08:03:32]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[James Cook, 2014-04-15 15:45:33]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-04-15 15:46:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/236213002/40001

[commit-bot: I haz the power, 2014-04-15 17:02:17]

Change committed as 263889

[tfarina, 2014-04-17 02:32:24]

https://codereview.chromium.org/236213002/diff/40001/extensions/common/file_u...
File extensions/common/file_util_unittest.cc (right):

https://codereview.chromium.org/236213002/diff/40001/extensions/common/file_u...
extensions/common/file_util_unittest.cc:9: #include
"base/files/scoped_temp_dir.h"
ought! that was lots of codes, he :)

https://codereview.chromium.org/236213002/diff/40001/extensions/common/file_u...
extensions/common/file_util_unittest.cc:19: #include
"grit/generated_resources.h"
this adds a dependency on chrome/chrome_resources.gyp:chrome_strings :/

since I had file_util_unittest.cc in extensions_unittests target this broke it
:(

../../extensions/common/file_util_unittest.cc:19:10: fatal error:
'grit/generated_resources.h' file not found
#include "grit/generated_resources.h"

I see two options here:

1- add the dependency on chrome_strings (will need extra ResourceBundlle setup I
bet).
2- remove this file from the extensions_unittests target for now.

The easiest one is 2, of course.

[James Cook, 2014-04-17 16:00:42]

On 2014/04/17 02:32:24, tfarina wrote:
>
https://codereview.chromium.org/236213002/diff/40001/extensions/common/file_u...
> File extensions/common/file_util_unittest.cc (right):
> 
>
https://codereview.chromium.org/236213002/diff/40001/extensions/common/file_u...
> extensions/common/file_util_unittest.cc:9: #include
> "base/files/scoped_temp_dir.h"
> ought! that was lots of codes, he :)
> 
>
https://codereview.chromium.org/236213002/diff/40001/extensions/common/file_u...
> extensions/common/file_util_unittest.cc:19: #include
> "grit/generated_resources.h"
> this adds a dependency on chrome/chrome_resources.gyp:chrome_strings :/
> 
> since I had file_util_unittest.cc in extensions_unittests target this broke it
> :(
> 
> ../../extensions/common/file_util_unittest.cc:19:10: fatal error:
> 'grit/generated_resources.h' file not found
> #include "grit/generated_resources.h"
> 
> I see two options here:
> 
> 1- add the dependency on chrome_strings (will need extra ResourceBundlle setup
I
> bet).
> 2- remove this file from the extensions_unittests target for now.
> 
> The easiest one is 2, of course.

I just landed https://codereview.chromium.org/239543005/ and file_util.cc
doesn't require generated_resources.h any more. Does that help?

[tfarina, 2014-04-17 16:11:34]

On 2014/04/17 16:00:42, James Cook wrote:
> I just landed https://codereview.chromium.org/239543005/ and file_util.cc
> doesn't require generated_resources.h any more. Does that help?
Sure, I will try later tonight.