Layout transitions triggered on key-down instead of key-up.

Layout transitions now triggered on key-down instead of key-up.
BUG=292727
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223462

[rsadam, 2013-09-16 17:08:25]

Changed when the layout transitions from key-up to key-down. All shift keys now
share the same long press timer.

[bshe, 2013-09-16 17:52:01]

lgtm with nits

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
File ui/keyboard/resources/elements/kb-key.html (right):

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-key.html:69: shiftLongPressTimer = undefined;
var shiftLongPressTimer = undefined
and @type {function}

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-key.html:104: 
nit: remove the empty line and indent seems off next line.

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
File ui/keyboard/resources/elements/kb-keyboard.html (right):

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-keyboard.html:416: var toKeysetId =
detail.toKeyset;
It is probably worth mention in a comment here about why we still have keyset
transition code here. I believe for non caps uppers case, this is still
necessary?

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-keyboard.html:471: detail.nextKeyset;
nit: accidentally removed the empty line?

[rsadam, 2013-09-16 18:23:48]

Fixed nits.

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
File ui/keyboard/resources/elements/kb-key.html (right):

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-key.html:69: shiftLongPressTimer = undefined;
On 2013/09/16 17:52:01, bshe wrote:
> var shiftLongPressTimer = undefined
> and @type {function}

Done.

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-key.html:104: 
On 2013/09/16 17:52:01, bshe wrote:
> nit: remove the empty line and indent seems off next line.

Done.

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
File ui/keyboard/resources/elements/kb-keyboard.html (right):

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-keyboard.html:416: var toKeysetId =
detail.toKeyset;
On 2013/09/16 17:52:01, bshe wrote:
> It is probably worth mention in a comment here about why we still have keyset
> transition code here. I believe for non caps uppers case, this is still
> necessary?

Done.

https://codereview.chromium.org/23621045/diff/3001/ui/keyboard/resources/elem...
ui/keyboard/resources/elements/kb-keyboard.html:471: detail.nextKeyset;
On 2013/09/16 17:52:01, bshe wrote:
> nit: accidentally removed the empty line?

Done.

[commit-bot: I haz the power, 2013-09-16 18:27:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsadam@chromium.org/23621045/2

[commit-bot: I haz the power, 2013-09-16 23:18:19]

Change committed as 223462