Issue 23621044: Revert "Add flags to force or prevent setting of isolate.is_memory_constrained."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23621044: Revert "Add flags to force or prevent setting of isolate.is_memory_constrained." (Closed)

Created:
7 years, 3 months ago by Sven Panne

Modified:
7 years, 3 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Add flags to force or prevent setting of isolate.is_memory_constrained." It introduces static initializers for the new "MAYBE_BOOL" kind of flags, which is a no-no for Chrome. This has to be done differently. TBR=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16736

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -59 lines)			Patch
M	src/api.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/flag-definitions.h	View	4 chunks	+0 lines, -7 lines	0 comments	Download
M	src/flags.cc	View	10 chunks	+3 lines, -26 lines	0 comments	Download
M	src/isolate.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	test/cctest/test-flags.cc	View	7 chunks	+6 lines, -19 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r16736.

Expand Messages | Collapse Messages