Make SSL False Start work with asynchronous certificate validation

net/third_party/nss/ssl/ssl3gthr.c

 /*
  * Gather (Read) entire SSL3 records from socket into buffer.  
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "cert.h"
 #include "ssl.h"
 #include "sslimpl.h"
@@ skipping 356 matching lines @@
         }
         if (rv < 0) {
             return ss->recvdCloseNotify ? 0 : rv;
         }
 
         /* If we kicked off a false start in ssl3_HandleServerHelloDone, break
          * out of this loop early without finishing the handshake.
          */
         if (ss->opt.enableFalseStart) {
             ssl_GetSSL3HandshakeLock(ss);
-            canFalseStart = (ss->ssl3.hs.ws == wait_change_cipher ||
-                             ss->ssl3.hs.ws == wait_new_session_ticket) &&

[wtc, 2013/09/18 22:57:23]

agl: do you remember why ss->ssl3.hs.ws == wait_finished isn't in this
conditional expression?

Compare this with the conditional expression in sslsecur.c (the original
code).

-                            ssl3_CanFalseStart(ss);
+            canFalseStart = ss->ssl3.hs.canFalseStart;
             ssl_ReleaseSSL3HandshakeLock(ss);
         }
     } while (ss->ssl3.hs.ws != idle_handshake &&
              !canFalseStart &&
              ss->gs.buf.len == 0);
 
     ss->gs.readOffset = 0;
     ss->gs.writeOffset = ss->gs.buf.len;
     return 1;
 }
@@ skipping 14 matching lines @@
 {
     int            rv;
 
     PORT_Assert( ss->opt.noLocks || ssl_HaveRecvBufLock(ss) );
     do {
         rv = ssl3_GatherCompleteHandshake(ss, flags);
     } while (rv > 0 && ss->gs.buf.len == 0);
 
     return rv;
 }