Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6468)

Unified Diff: chrome/browser/autocomplete/zero_suggest_provider.h

Issue 23621037: Send URLs on non-zero prefix suggest requests also. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/zero_suggest_provider.h
diff --git a/chrome/browser/autocomplete/zero_suggest_provider.h b/chrome/browser/autocomplete/zero_suggest_provider.h
index 7980f53020dbfcc4245ac71055dd2e44676f1f59..5fb9bece238c04e96420872f4a3469947bcf90e8 100644
--- a/chrome/browser/autocomplete/zero_suggest_provider.h
+++ b/chrome/browser/autocomplete/zero_suggest_provider.h
@@ -74,7 +74,7 @@ class ZeroSuggestProvider : public AutocompleteProvider,
// |page_classification|. |permanent_text| is the omnibox text
// for the current page.
void StartZeroSuggest(
- const GURL& url,
+ const GURL& curent_page_url,
AutocompleteInput::PageClassification page_classification,
const string16& permanent_text);
@@ -88,16 +88,6 @@ class ZeroSuggestProvider : public AutocompleteProvider,
virtual ~ZeroSuggestProvider();
- bool ShouldRunZeroSuggest(
- const GURL& url,
- AutocompleteInput::PageClassification page_classification) const;
-
- // Whether the URL can get Zero Suggest. For example, don't send the URL of
- // non-Google HTTPS requests because it may contain sensitive information.
- bool ShouldSendURL(
- const GURL& url,
- AutocompleteInput::PageClassification page_classification) const;
-
// The 4 functions below (that take classes defined in SearchProvider as
// arguments) were copied and trimmed from SearchProvider.
// TODO(hfung): Refactor them into a new base class common to both
@@ -135,8 +125,8 @@ class ZeroSuggestProvider : public AutocompleteProvider,
AutocompleteMatch NavigationToMatch(
const SearchProvider::NavigationResult& navigation);
- // Fetches zero-suggest suggestions for |current_query_|.
- void Run();
+ // Fetches zero-suggest suggestions by sending a request using |suggest_url|.
+ void Run(const GURL& suggest_url);
// Parses results from the zero-suggest server and updates results.
void ParseSuggestResults(const base::Value& root_val);

Powered by Google App Engine
This is Rietveld 408576698