Send URLs on non-zero prefix suggest requests also.

chrome/browser/autocomplete/search_provider.h

Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index 5993a46e73f72356e40ec1a5d1331533dcb6b1b1..e9231da529f00511e64b5160c3843e72244f10ac 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -98,6 +98,9 @@ class SearchProvider : public AutocompleteProvider,
   // stored for |match|.
   static std::string GetSuggestMetadata(const AutocompleteMatch& match);
 
+  // Set the URL of the current page to |url|.

[Peter Kasting, 2013/09/19 21:20:06]

This reads misleadingly.  We're not changing the URL of the current page, we're
notifying the search provider that the current page's URL has changed.

This should also note what we use this for, e.g. "This URL may be sent with
suggest requests; see comments on CanSendURL()".

[H Fung, 2013/09/21 01:13:25]

Done.

+  void SetCurrentPageUrl(const GURL& url);
+
   // AutocompleteProvider:
   virtual void AddProviderInfo(ProvidersInfo* provider_info) const OVERRIDE;
   virtual void ResetSession() OVERRIDE;
@@ -492,6 +495,13 @@ class SearchProvider : public AutocompleteProvider,
   // Updates the value of |done_| from the internal state.
   void UpdateDone();
 
+  // Whether the URL can be sent in the suggest request.  Don't send the URL of
+  // non-Google HTTPS requests because it may contain sensitive information.

[Peter Kasting, 2013/09/19 21:20:06]

It shouldn't be non-Google requests, it should be HTTPS requests with a domain
not matching that of the relevant search provider; see comments in .cc.

+  // Don't allow incognito, if suggest is disabled, no chrome sync or custom
+  // sync passphrase.  Checking that the user is in a field trial and that the

[Peter Kasting, 2013/09/19 21:20:06]

This description sounds like it needs updating based on the ongoing updates in
the other CL about sync/zero-suggest.

[H Fung, 2013/09/21 01:13:25]

Done.

+  // search provider is Google is done elsewhere.

[Peter Kasting, 2013/09/19 21:20:06]

We shouldn't limit this to just Google being the search provider.  Other
providers may legitimately want to do something like this.  (Anyway, I don't see
where that check actually does get done.)

The only reason I can see for doing this is that because sync always sends data
to Google, we view the "check sync status as proxy" behavior as only sufficient
for permission to send data to Google, not to an arbitrary provider.  But if
that's the reason, we should make that clear.

[H Fung, 2013/09/21 01:13:25]

It's clarified in the .cc file per your other comment.  I moved the check for
Google as a provider (from
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/aut...)
to this function since I realized SearchProvider needs to check also.

+  static bool CanSendURL(const GURL& url, Profile *profile);
+
   // The amount of time to wait before sending a new suggest request after the
   // previous one.  Non-const because some unittests modify this value.
   static int kMinimumTimeBetweenSuggestQueriesMs;
@@ -561,6 +571,8 @@ class SearchProvider : public AutocompleteProvider,
   // they will not be inlined.
   bool prevent_search_history_inlining_;
 
+  GURL current_page_url_;
+
   DISALLOW_COPY_AND_ASSIGN(SearchProvider);
 };