Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Side by Side Diff: chrome/browser/omnibox/omnibox_field_trial.h

Issue 23621037: Send URLs on non-zero prefix suggest requests also. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_ 5 #ifndef CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
6 #define CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_ 6 #define CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 // Returns whether the user is in any field trial where the 95 // Returns whether the user is in any field trial where the
96 // ZeroSuggestProvider should be used to get suggestions when the 96 // ZeroSuggestProvider should be used to get suggestions when the
97 // user clicks on the omnibox but has not typed anything yet. 97 // user clicks on the omnibox but has not typed anything yet.
98 static bool InZeroSuggestFieldTrial(); 98 static bool InZeroSuggestFieldTrial();
99 99
100 // Returns whether the user is in a ZeroSuggest field trial, but should 100 // Returns whether the user is in a ZeroSuggest field trial, but should
101 // show most visited URL instead. This is used to compare metrics of 101 // show most visited URL instead. This is used to compare metrics of
102 // ZeroSuggest and most visited suggestions. 102 // ZeroSuggest and most visited suggestions.
103 static bool InZeroSuggestMostVisitedFieldTrial(); 103 static bool InZeroSuggestMostVisitedFieldTrial();
104 104
105 // Returns whether the user is in a ZeroSuggest field trial and URL-based
106 // suggestions can continue to appear after the user has started typing.
107 static bool InZeroSuggestAfterTypingFieldTrial();
108
105 // --------------------------------------------------------- 109 // ---------------------------------------------------------
106 // For the ShortcutsScoringMaxRelevance experiment that's part of the 110 // For the ShortcutsScoringMaxRelevance experiment that's part of the
107 // bundled omnibox field trial. 111 // bundled omnibox field trial.
108 112
109 // If the user is in an experiment group that, given the provided 113 // If the user is in an experiment group that, given the provided
110 // |current_page_classification| context, changes the maximum relevance 114 // |current_page_classification| context, changes the maximum relevance
111 // ShortcutsProvider::CalculateScore() is supposed to assign, extract 115 // ShortcutsProvider::CalculateScore() is supposed to assign, extract
112 // that maximum relevance score and put in in |max_relevance|. Returns 116 // that maximum relevance score and put in in |max_relevance|. Returns
113 // true on a successful extraction. CalculateScore()'s return value is 117 // true on a successful extraction. CalculateScore()'s return value is
114 // a product of this maximum relevance score and some attenuating factors 118 // a product of this maximum relevance score and some attenuating factors
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 // prioritize different wildcard contexts, see the implementation. How to 195 // prioritize different wildcard contexts, see the implementation. How to
192 // interpret the value is left to the caller; this is rule-dependent. 196 // interpret the value is left to the caller; this is rule-dependent.
193 static std::string GetValueForRuleInContext( 197 static std::string GetValueForRuleInContext(
194 const std::string& rule, 198 const std::string& rule,
195 AutocompleteInput::PageClassification page_classification); 199 AutocompleteInput::PageClassification page_classification);
196 200
197 DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial); 201 DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
198 }; 202 };
199 203
200 #endif // CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_ 204 #endif // CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698