Send URLs on non-zero prefix suggest requests also.

chrome/browser/autocomplete/search_provider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the Search autocomplete provider.  This provider is
 // responsible for all autocomplete entries that start with "Search <engine>
 // for ...", including searching for the current input string, search
 // history, and search suggestions.  An instance of it gets created and
 // managed by the autocomplete controller.
 
@@ skipping 88 matching lines @@
   static std::string GetSuggestMetadata(const AutocompleteMatch& match);
 
   // AutocompleteProvider:
   virtual void AddProviderInfo(ProvidersInfo* provider_info) const OVERRIDE;
   virtual void ResetSession() OVERRIDE;
 
   bool field_trial_triggered_in_session() const {
     return field_trial_triggered_in_session_;
   }
 
+  // This URL may be sent with suggest requests; see comments on CanSendURL().
+  void set_current_page_url(const GURL& url) {

[Peter Kasting, 2013/10/08 01:10:25]

Tiny nit: Name the arg |current_page_url|

[H Fung, 2013/10/30 23:56:15]

Done.

+    current_page_url_ = url;
+  }
+
  private:
   // TODO(hfung): Remove ZeroSuggestProvider as a friend class after
   // refactoring common code to a new base class.
   friend class SearchProviderTest;
   friend class ZeroSuggestProvider;
   FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInline);
   FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInlineDomainClassify);
   FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInlineSchemeSubstring);
   FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, RemoveStaleResultsTest);
   FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, SuggestRelevanceExperiment);
@@ skipping 366 matching lines @@
   // suggestions stored in |keyword_suggest_results_|).  If there
   // are no keyword suggestions and keyword verbatim is suppressed,
   // then drops the suggested relevance scores for the navsuggestions
   // and drops the request to suppress verbatim, thereby introducing the
   // keyword verbatim match which will naturally outscore the navsuggestions.
   void DemoteKeywordNavigationMatchesPastTopQuery();
 
   // Updates the value of |done_| from the internal state.
   void UpdateDone();
 
+  // Whether the URL can be sent in the suggest request.  Don't send the URL of
+  // non-Google HTTPS requests because it may contain sensitive information.

[Peter Kasting, 2013/10/08 01:10:25]

Nit: This sentence is kinda redundant with the ones below and should probably
just be removed.

[H Fung, 2013/10/30 23:56:15]

Done.

+  // Don't allow incognito, if suggest is disabled, if they don't have

[Peter Kasting, 2013/10/08 01:10:25]

Nit: incognito -> if Chrome is incognito?

[H Fung, 2013/10/30 23:56:15]

Done.

+  // unencrypted tab sync enabled, or if Google is not their search provider.

[Peter Kasting, 2013/10/08 01:10:25]

Nit: their -> the user's

[H Fung, 2013/10/30 23:56:15]

Done.

+  // Checking that the user is in a field trial is done elsewhere.

[Peter Kasting, 2013/10/08 01:10:25]

This line seems to be false now.

[H Fung, 2013/10/30 23:56:15]

Done.

+  static bool CanSendURL(const GURL& url, const TemplateURL* template_url,

[Peter Kasting, 2013/10/08 01:10:25]

Nit: One arg per line

[H Fung, 2013/10/30 23:56:15]

Done.

+                         Profile* profile);
+
   // The amount of time to wait before sending a new suggest request after the
   // previous one.  Non-const because some unittests modify this value.
   static int kMinimumTimeBetweenSuggestQueriesMs;
 
   // The following keys are used to record additional information on matches.
 
   // We annotate our AutocompleteMatches with whether their relevance scores
   // were server-provided using this key in the |additional_info| field.
   static const char kRelevanceFromServerKey[];
 
@@ skipping 49 matching lines @@
   bool field_trial_triggered_;
 
   // Same as above except that it is maintained across the current Omnibox
   // session.
   bool field_trial_triggered_in_session_;
 
   // If true, search history query suggestions will score low enough that
   // they will not be inlined.
   bool prevent_search_history_inlining_;
 
+  GURL current_page_url_;
+
   DISALLOW_COPY_AND_ASSIGN(SearchProvider);
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_SEARCH_PROVIDER_H_