Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp

Issue 2362103002: {CSS,XSL}StyleSheetResource should mark their clients as finished on checkNotify (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 6 Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 return decodedText(); 99 return decodedText();
100 } 100 }
101 101
102 void CSSStyleSheetResource::checkNotify() 102 void CSSStyleSheetResource::checkNotify()
103 { 103 {
104 // Decode the data to find out the encoding and keep the sheet text around d uring checkNotify() 104 // Decode the data to find out the encoding and keep the sheet text around d uring checkNotify()
105 if (m_data) 105 if (m_data)
106 m_decodedSheetText = decodedText(); 106 m_decodedSheetText = decodedText();
107 107
108 ResourceClientWalker<StyleSheetResourceClient> w(m_clients); 108 ResourceClientWalker<StyleSheetResourceClient> w(m_clients);
109 while (StyleSheetResourceClient* c = w.next()) 109 while (StyleSheetResourceClient* c = w.next()) {
110 c->setCSSStyleSheet(m_resourceRequest.url(), m_response.url(), encoding( ), this); 110 markClientFinished(c);
111 c->setCSSStyleSheet(resourceRequest().url(), response().url(), encoding( ), this);
112 }
111 // Clear the decoded text as it is unlikely to be needed immediately again a nd is cheap to regenerate. 113 // Clear the decoded text as it is unlikely to be needed immediately again a nd is cheap to regenerate.
112 m_decodedSheetText = String(); 114 m_decodedSheetText = String();
113 } 115 }
114 116
115 bool CSSStyleSheetResource::isSafeToUnlock() const 117 bool CSSStyleSheetResource::isSafeToUnlock() const
116 { 118 {
117 return m_data->hasOneRef(); 119 return m_data->hasOneRef();
118 } 120 }
119 121
120 void CSSStyleSheetResource::destroyDecodedDataIfPossible() 122 void CSSStyleSheetResource::destroyDecodedDataIfPossible()
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 // This stylesheet resource did conflict with another resource and was 175 // This stylesheet resource did conflict with another resource and was
174 // not added to the cache. 176 // not added to the cache.
175 setParsedStyleSheetCache(nullptr); 177 setParsedStyleSheetCache(nullptr);
176 return; 178 return;
177 } 179 }
178 setParsedStyleSheetCache(sheet); 180 setParsedStyleSheetCache(sheet);
179 setDecodedSize(m_parsedStyleSheetCache->estimatedSizeInBytes()); 181 setDecodedSize(m_parsedStyleSheetCache->estimatedSizeInBytes());
180 } 182 }
181 183
182 } // namespace blink 184 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698