[SVG] Handle repeatEvent for svg animations

Source/core/svg/animation/SVGSMILElement.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 39 matching lines @@
     DEFINE_STATIC_LOCAL(SMILEventSender, sender, ("endEvent"));
     return sender;
 }
 
 static SMILEventSender& smilBeginEventSender()
 {
     DEFINE_STATIC_LOCAL(SMILEventSender, sender, ("beginEvent"));
     return sender;
 }
 
+static SMILEventSender& smilRepeatEventSender()
+{
+    DEFINE_STATIC_LOCAL(SMILEventSender, sender, ("repeatEvent"));
+    return sender;
+}
+
 // This is used for duration type time values that can't be negative.
 static const double invalidCachedTime = -1.;
 
 class ConditionEventListener : public EventListener {
 public:
     static PassRefPtr<ConditionEventListener> create(SVGSMILElement* animation, SVGSMILElement::Condition* condition)
     {
         return adoptRef(new ConditionEventListener(animation, condition));
     }
 
@@ skipping 71 matching lines @@
     , m_cachedMax(invalidCachedTime)
 {
     resolveFirstInterval();
 }
 
 SVGSMILElement::~SVGSMILElement()
 {
     clearResourceReferences();
     smilEndEventSender().cancelEvent(this);
     smilBeginEventSender().cancelEvent(this);
+    smilRepeatEventSender().cancelEvent(this);
     disconnectConditions();
     if (m_timeContainer && m_targetElement && hasValidAttributeName())
         m_timeContainer->unschedule(this, m_targetElement, m_attributeName);
 }
 
 void SVGSMILElement::clearResourceReferences()
 {
     document().accessSVGExtensions()->removeAllTargetReferencesForElement(this);
 }
 
@@ skipping 949 matching lines @@
     // Only reset the animated type to the base value once for the lowest priority animation that animates and contributes to a particular element/attribute pair.
     if (this == resultElement && animationIsContributing)
         resetAnimatedType();
 
     if (animationIsContributing) {
         if (oldActiveState == Inactive) {
             smilBeginEventSender().dispatchEventSoon(this);
             startedActiveInterval();
         }
 
+        if (repeat && repeat != m_lastRepeat)
+            smilRepeatEventSender().dispatchEventSoon(this);
+
         updateAnimation(percent, repeat, resultElement);
         m_lastPercent = percent;
         m_lastRepeat = repeat;
     }
 
     if (oldActiveState == Active && m_activeState != Active) {
         smilEndEventSender().dispatchEventSoon(this);
         endedActiveInterval();
         if (m_activeState != Frozen && this == resultElement)
             clearAnimatedType(m_targetElement);
     }
 
     // Triggering all the pending events if the animation timeline is changed.

[pdr., 2013/08/31 02:28:08]

Does the order that you fire these matter?

[pavane, 2013/08/31 03:30:11]

I don't think so. Specification doesn't define anything about this. I
implemented these events based on the behavior of Opera and Firefox and based on
whatever i could think of logically. For safe side i will put these in order.

     if (seekToTime) {
         if (m_activeState == Inactive)
             smilBeginEventSender().dispatchEventSoon(this);
         if (m_activeState == Inactive || m_activeState == Frozen)
             smilEndEventSender().dispatchEventSoon(this);
+        if (repeat) {
+            int count = 1;
+            while (count < repeat) {

[pdr., 2013/08/31 02:28:08]

A for loop would be cleaner here:
for (int repeatEventCount = 1; repeatEventCount < repeat; repeatEventCount++)
  smilRepeatEventSender().dispatchEventSoon(this);

[pavane, 2013/08/31 03:30:11]

done.

+                smilRepeatEventSender().dispatchEventSoon(this);
+                count++;
+            }
+            if (m_activeState == Inactive)
+                smilRepeatEventSender().dispatchEventSoon(this);
+        }
     }
 
     m_nextProgressTime = calculateNextProgressTime(elapsed);
     return animationIsContributing;
 }
 
 void SVGSMILElement::notifyDependentsIntervalChanged(NewOrExistingInterval newOrExisting)
 {
     ASSERT(m_intervalBegin.isFinite());
     DEFINE_STATIC_LOCAL(HashSet<SVGSMILElement*>, loopBreaker, ());
@@ skipping 60 matching lines @@
 }
 
 void SVGSMILElement::endedActiveInterval()
 {
     clearTimesWithDynamicOrigins(m_beginTimes);
     clearTimesWithDynamicOrigins(m_endTimes);
 }
 
 void SVGSMILElement::dispatchPendingEvent(SMILEventSender* eventSender)
 {
-    ASSERT(eventSender == &smilEndEventSender() || eventSender == &smilBeginEventSender());
+    ASSERT(eventSender == &smilEndEventSender() || eventSender == &smilBeginEventSender() || eventSender == &smilRepeatEventSender());
     const AtomicString& eventType = eventSender->eventType();
     dispatchEvent(Event::create(eventType));
 }
 
 }