LayoutTests/svg/animations/repeat-event.svg - Issue 23621018: [SVG] Handle repeatEvent for svg animations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/animations/repeat-event.svg

Issue 23621018: [SVG] Handle repeatEvent for svg animations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="UTF-8"?>
	pdr. 2013/08/31 02:28:08 This is a good test but I wonder if you could add This is a good test but I wonder if you could add an additional test that the repeat event fires multiple times? You may be able to use additive animations to do this, where an animation begins on anim.repeatEvent and runs twice. You may have to use JS to do this, I'm not sure.
	2 <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/ SVG/1.1/DTD/svg11-tiny.dtd">

	3 <svg onload="loaded()" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://ww w.w3.org/1999/xlink">

	4 <rect x="0" y="0" width="0" height="0" fill="green">

	5 <animate id="anim" attributeName="width" from="0" to="100" begin="0s" dur="1 s" repeatCount="2" fill="freeze"/>

	6 <set attributeName="height" to="100" begin="anim.repeatEvent"/>

	7 </rect>

	8 <script>

	9 if (window.testRunner)

	10 testRunner.waitUntilDone();

	11

	12 function loaded() {

	13 document.documentElement.setCurrentTime(2);

	14

	15 if (window.testRunner)

	16 setTimeout(function(){testRunner.notifyDone();}, 100);

	17 }

	18 </script>

	19 </svg>

OLD	NEW