fix issue on devices running an OS prior to 4.2 when the fallback font file was potential stored in…

fix issue on devices running an OS prior to 4.2 when the fallback font file was potential stored in a different location on device.

BUG=chromium:183830
R=scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10972

[scroggo, 2013-08-27 19:14:01]

lgtm

https://codereview.chromium.org/23621002/diff/1/src/ports/SkFontConfigParser_...
File src/ports/SkFontConfigParser_android.cpp (right):

https://codereview.chromium.org/23621002/diff/1/src/ports/SkFontConfigParser_...
src/ports/SkFontConfigParser_android.cpp:169: #if
!defined(SK_BUILD_FOR_ANDROID_FRAMEWORK)
So this is only for Android, but not in the framework?

https://codereview.chromium.org/23621002/diff/1/src/ports/SkFontConfigParser_...
src/ports/SkFontConfigParser_android.cpp:179: SkString locale =
SkFontConfigParser::GetLocale();
could be const.

[mtklein, 2013-08-27 19:18:09]

How do we add a test for this?

[djsollen, 2013-08-27 19:22:49]

https://codereview.chromium.org/23621002/diff/1/src/ports/SkFontConfigParser_...
File src/ports/SkFontConfigParser_android.cpp (right):

https://codereview.chromium.org/23621002/diff/1/src/ports/SkFontConfigParser_...
src/ports/SkFontConfigParser_android.cpp:169: #if
!defined(SK_BUILD_FOR_ANDROID_FRAMEWORK)
On 2013/08/27 19:14:01, scroggo wrote:
> So this is only for Android, but not in the framework?

This code will not be possible to run as part of the framework in versions prior
to 4.2 as they have already shipped. This guard just means we don't need to do
the extra work to reach that conclusion.

[djsollen, 2013-08-28 12:30:46]

Committed patchset #1 manually as r10972.