Find reading list entry state in model from url

Find reading list entry state in model from url

This CL adds a method in ReadingListModel to find the state of an entry in the
model (not present, read, unread) base on the entry url.

BUG=none

[gambard, 2016-09-23 12:52:34]

gambard@chromium.org changed reviewers:
+ olivierrobin@google.com

[gambard, 2016-09-23 12:52:34]

PTAL.

[gambard, 2016-09-23 13:40:42]

gambard@chromium.org changed reviewers:
+ olivierrobin@chromium.org
- olivierrobin@google.com

[Olivier, 2016-09-23 14:54:54]

https://codereview.chromium.org/2362063004/diff/20001/ios/chrome/browser/read...
File ios/chrome/browser/reading_list/reading_list_model.h (right):

https://codereview.chromium.org/2362063004/diff/20001/ios/chrome/browser/read...
ios/chrome/browser/reading_list/reading_list_model.h:34: enum EntryState {
NOTPRESENT, READ, UNREAD };
NOT_PRESENT?

https://codereview.chromium.org/2362063004/diff/20001/ios/chrome/browser/read...
ios/chrome/browser/reading_list/reading_list_model.h:89: virtual EntryState
EntryPositionByURL(const GURL& url) = 0;
position is more an index IMO.

[gambard, 2016-09-26 14:02:30]

Thanks, PTAL.

https://codereview.chromium.org/2362063004/diff/20001/ios/chrome/browser/read...
File ios/chrome/browser/reading_list/reading_list_model.h (right):

https://codereview.chromium.org/2362063004/diff/20001/ios/chrome/browser/read...
ios/chrome/browser/reading_list/reading_list_model.h:34: enum EntryState {
NOTPRESENT, READ, UNREAD };
On 2016/09/23 14:54:54, Olivier Robin wrote:
> NOT_PRESENT?

Done.

https://codereview.chromium.org/2362063004/diff/20001/ios/chrome/browser/read...
ios/chrome/browser/reading_list/reading_list_model.h:89: virtual EntryState
EntryPositionByURL(const GURL& url) = 0;
On 2016/09/23 14:54:54, Olivier Robin wrote:
> position is more an index IMO.

Done.

[Olivier, 2016-09-27 08:55:33]

https://codereview.chromium.org/2362063004/diff/40001/ios/chrome/browser/read...
File ios/chrome/browser/reading_list/reading_list_model.h (right):

https://codereview.chromium.org/2362063004/diff/40001/ios/chrome/browser/read...
ios/chrome/browser/reading_list/reading_list_model.h:89: virtual EntryState
EntryStateByURL(const GURL& url) = 0;
How will this be used differently from CallbackEntryURL ?

[gambard, 2016-09-27 15:59:34]

https://codereview.chromium.org/2362063004/diff/40001/ios/chrome/browser/read...
File ios/chrome/browser/reading_list/reading_list_model.h (right):

https://codereview.chromium.org/2362063004/diff/40001/ios/chrome/browser/read...
ios/chrome/browser/reading_list/reading_list_model.h:89: virtual EntryState
EntryStateByURL(const GURL& url) = 0;
On 2016/09/27 08:55:33, Olivier Robin wrote:
> How will this be used differently from CallbackEntryURL ?

This is just to know if it exists an entry with this URL and if it does, if it
is read or unread.

[Olivier, 2016-10-04 08:54:38]

olivierrobin@chromium.org changed reviewers:
+ jif@chromium.org, noyau@chromium.org

[Olivier, 2016-10-04 08:54:38]

I don't really like the mixing of exist/not exist, read/unread state.
+noyau, jif to see if they have better ideas.

[noyau (Ping after 24h), 2016-10-04 09:13:26]

https://codereview.chromium.org/2362063004/diff/40001/ios/chrome/browser/read...
File ios/chrome/browser/reading_list/reading_list_model.h (right):

https://codereview.chromium.org/2362063004/diff/40001/ios/chrome/browser/read...
ios/chrome/browser/reading_list/reading_list_model.h:89: virtual EntryState
EntryStateByURL(const GURL& url) = 0;
On 2016/09/27 15:59:34, gambard wrote:
> On 2016/09/27 08:55:33, Olivier Robin wrote:
> > How will this be used differently from CallbackEntryURL ?
> 
> This is just to know if it exists an entry with this URL and if it does, if it
> is read or unread.

There is no reason to have two methods doing the same thing. What you need is
one API returning the state (READ/UNREAD) and the entry itself. The simplest way
to do this is to change CallbackEntryURL (which could have a better name like
FindEntryByURL) to pass another argument to the callback to denote if it is in
the read or the unread list.

[gambard, 2016-10-05 06:55:28]

Closing this issue, the change to the model made it unnecessary.