Clean up xfa_fontmgr.cpp.

Clean up xfa_fontmgr.cpp.

Committed: https://pdfium.googlesource.com/pdfium/+/2c065322f1b14ca3ff145dc068ab2361704f9e4b

[Lei Zhang, 2016-09-23 06:13:04]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 06:13:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 06:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 06:30:25]

Dry run: Try jobs failed on following builders:
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[Lei Zhang, 2016-09-23 07:00:14]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 07:00:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 09:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 09:01:03]

Dry run: Try jobs failed on following builders:
  mac on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)
  mac_no_v8 on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)
  mac_xfa on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)
  win on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)
  win_no_v8 on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)
  win_xfa on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)
  win_xfa_clang on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)

[Lei Zhang, 2016-09-23 20:33:47]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 20:33:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 20:38:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 20:38:19]

Dry run: Try jobs failed on following builders:
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Lei Zhang, 2016-09-23 20:44:27]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 20:44:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-09-23 21:07:30]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 21:07:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-09-23 21:22:48]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 21:22:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-09-23 21:30:06]

thestig@chromium.org changed reviewers:
+ npm@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:35:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:35:05]

Dry run: This issue passed the CQ dry run.

[npm, 2016-09-23 22:14:51]

lgtm

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/font/fgas_gefo...
File xfa/fgas/font/fgas_gefont.cpp (right):

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/font/fgas_gefo...
xfa/fgas/font/fgas_gefont.cpp:345: m_pCharWidthMap->SetAtGrow(wUnicode,
(int16_t)iWidth);
Remove C-Cast

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/layout/fgas_rt...
File xfa/fgas/layout/fgas_rtfbreak.cpp (left):

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.cpp:651: goto EndBreak_Ret;
Oh wow

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/layout/fgas_rt...
File xfa/fgas/layout/fgas_rtfbreak.cpp (right):

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.cpp:593: if (!m_pFont->GetCharWidth(wForm,
iCharWidth, m_bCharCode)) {
Nit: remove {}

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.cpp:600: if (chartype == FX_CHARTYPE_Space &&
m_bWordSpace) {
Ditto

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.cpp:612: }
Nit: space between methods

https://codereview.chromium.org/2362063003/diff/80001/xfa/fxfa/app/xfa_fontmg...
File xfa/fxfa/app/xfa_fontmgr.cpp (right):

https://codereview.chromium.org/2362063003/diff/80001/xfa/fxfa/app/xfa_fontmg...
xfa/fxfa/app/xfa_fontmgr.cpp:1819: CFGAS_GEFont* CXFA_PDFFontMgr::FindFont(const
CFX_ByteString& strPsName,
Why the & here? Clarity I imagine?

[Lei Zhang, 2016-09-26 21:00:02]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 21:00:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-09-26 21:00:25]

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/font/fgas_gefo...
File xfa/fgas/font/fgas_gefont.cpp (right):

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/font/fgas_gefo...
xfa/fgas/font/fgas_gefont.cpp:345: m_pCharWidthMap->SetAtGrow(wUnicode,
(int16_t)iWidth);
On 2016/09/23 22:14:50, npm wrote:
> Remove C-Cast

Done.

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/layout/fgas_rt...
File xfa/fgas/layout/fgas_rtfbreak.cpp (right):

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.cpp:593: if (!m_pFont->GetCharWidth(wForm,
iCharWidth, m_bCharCode)) {
On 2016/09/23 22:14:50, npm wrote:
> Nit: remove {}

Done.

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.cpp:600: if (chartype == FX_CHARTYPE_Space &&
m_bWordSpace) {
On 2016/09/23 22:14:51, npm wrote:
> Ditto

Done.

https://codereview.chromium.org/2362063003/diff/80001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.cpp:612: }
On 2016/09/23 22:14:50, npm wrote:
> Nit: space between methods

Done.

https://codereview.chromium.org/2362063003/diff/80001/xfa/fxfa/app/xfa_fontmg...
File xfa/fxfa/app/xfa_fontmgr.cpp (right):

https://codereview.chromium.org/2362063003/diff/80001/xfa/fxfa/app/xfa_fontmg...
xfa/fxfa/app/xfa_fontmgr.cpp:1819: CFGAS_GEFont* CXFA_PDFFontMgr::FindFont(const
CFX_ByteString& strPsName,
On 2016/09/23 22:14:51, npm wrote:
> Why the & here? Clarity I imagine?

Pass by const-ref, not by value.

[commit-bot: I haz the power, 2016-09-26 21:11:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 21:11:19]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-26 21:16:23]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-09-26 21:16:23]

The patchset sent to the CQ was uploaded after l-g-t-m from npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2362063003/#ps100001
(title: "nits")

[commit-bot: I haz the power, 2016-09-26 21:16:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 21:16:46]

Description was changed from

==========
Clean up xfa_fontmgr.cpp.
==========

to

==========
Clean up xfa_fontmgr.cpp.

Committed:
https://pdfium.googlesource.com/pdfium/+/2c065322f1b14ca3ff145dc068ab2361704f...
==========

[commit-bot: I haz the power, 2016-09-26 21:16:47]

Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/2c065322f1b14ca3ff145dc068ab2361704f...