cros: Laser pointer fades out on release, do not cover palette.

ash/laser/laser_pointer_points.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/laser/laser_pointer_points.h"
 
 #include <algorithm>
 #include <limits>
 
 namespace ash {
 
 LaserPointerPoints::LaserPointerPoints(base::TimeDelta life_duration)
     : life_duration_(life_duration) {}
 
 LaserPointerPoints::~LaserPointerPoints() {}
 
 void LaserPointerPoints::AddPoint(const gfx::Point& point) {
+  base::Time current_time = base::Time::Now();

[jdufault, 2016/10/05 18:08:51]

Remove this helper variable.

[sammiequon, 2016/10/05 21:15:22]

Done.

   LaserPoint new_point;
   new_point.location = point;
-  new_point.creation_time = base::Time::Now();
+  new_point.age = 0.0;
+  MoveForwardToTime(current_time);
   points_.push_back(new_point);
+}
+
+void LaserPointerPoints::MoveForwardToCurrentTime() {
+  MoveForwardToTime(base::Time::Now());
+}
+
+void LaserPointerPoints::MoveForwardToTime(const base::Time& new_latest_time) {
+  if (collection_latest_time_.is_null())
+    collection_latest_time_ = new_latest_time;
+
+  // Update the ages of the points based on the change in new latest time.
+  auto delta = new_latest_time - collection_latest_time_;

[jdufault, 2016/10/05 18:08:51]

Specify type

[sammiequon, 2016/10/05 21:15:22]

Done.

+  double lifespan_change =
+      delta.InMillisecondsF() / life_duration_.InMillisecondsF();
+  for (auto& point : points_)

[jdufault, 2016/10/05 18:08:51]

Specify type

[sammiequon, 2016/10/05 21:15:22]

Done.

+    point.age += lifespan_change;
   ClearOldPoints();
+  collection_latest_time_ = new_latest_time;
 }
 
 void LaserPointerPoints::Clear() {
   points_.clear();
 }
 
 gfx::Rect LaserPointerPoints::GetBoundingBox() {
   if (IsEmpty())
     return gfx::Rect();
 
@@ skipping 23 matching lines @@
 int LaserPointerPoints::GetNumberOfPoints() const {
   return points_.size();
 }
 
 const std::deque<LaserPointerPoints::LaserPoint>&
 LaserPointerPoints::laser_points() {
   return points_;
 }
 
 void LaserPointerPoints::ClearOldPoints() {
-  DCHECK(!IsEmpty());
   auto first_alive_point =
-      std::find_if(points_.begin(), points_.end(), [this](LaserPoint& p) {
-        return GetNewest().creation_time - p.creation_time < life_duration_;
-      });
+      std::find_if(points_.begin(), points_.end(),
+                   [](LaserPoint& p) { return p.age < 1.0; });
   points_.erase(points_.begin(), first_alive_point);
 }
-
 }  // namespace ash