cros: Laser pointer fades out on release, do not cover palette.

ash/laser/laser_pointer_points.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/laser/laser_pointer_points.h"
 
 #include <algorithm>
 #include <limits>
 
+#include "base/macros.h"

[jdufault, 2016/10/13 00:12:30]

Include this in the header file since you're using DISALLOW_COPY_AND_ASSIGN.

[sammiequon, 2016/10/14 18:48:50]

Done.

+
 namespace ash {
 
 LaserPointerPoints::LaserPointerPoints(base::TimeDelta life_duration)
     : life_duration_(life_duration) {}
 
 LaserPointerPoints::~LaserPointerPoints() {}
 
 void LaserPointerPoints::AddPoint(const gfx::Point& point) {
+  MoveForwardToTime(base::Time::Now());
+
   LaserPoint new_point;
   new_point.location = point;
-  new_point.creation_time = base::Time::Now();
+  new_point.age = 0.0;
   points_.push_back(new_point);
-  ClearOldPoints();
+}
+
+void LaserPointerPoints::MoveForwardToTime(const base::Time& latest_time) {
+  if (!points_.empty()) {
+    // Update the ages of the points based on the change in new latest time.

[jdufault, 2016/10/13 00:12:30]

What about

// Increase the age of points based on how much time has elapsed.

[jdufault, 2016/10/13 00:12:30]

DCHECK(!collection_latest_time_.is_null());

[sammiequon, 2016/10/14 18:48:50]

Done.

[sammiequon, 2016/10/14 18:48:50]

Done.

+    base::TimeDelta delta = latest_time - collection_latest_time_;
+    double lifespan_change =
+        delta.InMillisecondsF() / life_duration_.InMillisecondsF();
+    for (LaserPoint& point : points_)
+      point.age += lifespan_change;
+
+    // Remove points that are too old (points age older than 1.0).
+    auto first_alive_point =
+        std::find_if(points_.begin(), points_.end(),
+                     [](LaserPoint& p) { return p.age < 1.0; });
+    points_.erase(points_.begin(), first_alive_point);
+  }
+  collection_latest_time_ = latest_time;
 }
 
 void LaserPointerPoints::Clear() {
   points_.clear();
 }
 
 gfx::Rect LaserPointerPoints::GetBoundingBox() {
   if (IsEmpty())
     return gfx::Rect();
 
@@ skipping 21 matching lines @@
 }
 
 int LaserPointerPoints::GetNumberOfPoints() const {
   return points_.size();
 }
 
 const std::deque<LaserPointerPoints::LaserPoint>&
 LaserPointerPoints::laser_points() {
   return points_;
 }
-
-void LaserPointerPoints::ClearOldPoints() {
-  DCHECK(!IsEmpty());
-  auto first_alive_point =
-      std::find_if(points_.begin(), points_.end(), [this](LaserPoint& p) {
-        return GetNewest().creation_time - p.creation_time < life_duration_;
-      });
-  points_.erase(points_.begin(), first_alive_point);
-}
-
 }  // namespace ash