Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2193)

Unified Diff: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc

Issue 2362033002: Showing previews UI for Offline Previews (Closed)
Patch Set: java fixes for mocking methods Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
index 56981a3f71bc362fdae31de14f501d6887620499..a9e0815c083ae27784bd7b9fe4baace2185c6dbf 100644
--- a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
@@ -105,17 +105,17 @@ void PreviewsPageLoadMetricsObserver::OnParseStart(
}
PAGE_LOAD_HISTOGRAM(internal::kHistogramOfflinePreviewsParseStart,
timing.parse_start.value());
}
bool PreviewsPageLoadMetricsObserver::IsOfflinePreview(
content::WebContents* web_contents) const {
#if BUILDFLAG(ANDROID_JAVA_UI)
offline_pages::OfflinePageTabHelper* tab_helper =
offline_pages::OfflinePageTabHelper::FromWebContents(web_contents);
- return tab_helper && tab_helper->is_offline_preview();
+ return tab_helper && tab_helper->IsShowingOfflinePreview();
#else
return false;
#endif // BUILDFLAG(ANDROID_JAVA_UI)
}
} // namespace previews
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | chrome/browser/previews/previews_infobar_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698