Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java |
| index 28749599ffd23977b2eb4bb1add408893fcc9f34..bc1c2ae6958cb4f37f6667fefaccae33e5253b45 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java |
| @@ -213,22 +213,22 @@ public class OfflinePageTabObserver |
| return mIsObservingNetworkChanges; |
| } |
| @VisibleForTesting |
| boolean isConnected() { |
| return OfflinePageUtils.isConnected(); |
| } |
| void maybeShowReloadSnackbar(Tab tab, boolean isNetworkEvent) { |
| if (tab == null || tab.isFrozen() || tab.isHidden() || !tab.isOfflinePage() |
| - || !isConnected() || !isLoadedTab(tab) |
| - || (wasSnackbarSeen(tab) && !isNetworkEvent)) { |
| + || OfflinePageUtils.isShowingOfflinePreview(tab) || !isConnected() |
|
jianli
2016/10/25 23:55:27
Please comment why we exclude offline preview case
RyanSturm
2016/10/27 00:01:01
Done.
|
| + || !isLoadedTab(tab) || (wasSnackbarSeen(tab) && !isNetworkEvent)) { |
| // Conditions to show a snackbar are not met. |
| return; |
| } |
| showReloadSnackbar(tab); |
| mObservedTabs.get(tab.getId()).wasSnackbarSeen = true; |
| } |
| @VisibleForTesting |
| void showReloadSnackbar(Tab tab) { |