Source/core/rendering/svg/RenderSVGInlineText.cpp - Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGInlineText.cpp

Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update layout test expectations Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/RenderSVGInlineText.cpp

diff --git a/Source/core/rendering/svg/RenderSVGInlineText.cpp b/Source/core/rendering/svg/RenderSVGInlineText.cpp

index a2963920bb5636c49357f98c0617efcd5577b5fe..3f212fd04ca619225642843f2bcf46a52cbd47fe 100644

--- a/Source/core/rendering/svg/RenderSVGInlineText.cpp

+++ b/Source/core/rendering/svg/RenderSVGInlineText.cpp

@@ -89,7 +89,7 @@ void RenderSVGInlineText::styleDidChange(StyleDifference diff, const RenderStyle

return;

}

- if (diff != StyleDifferenceLayout)

+ if (!diff.needsFullLayout())

return;

// The text metrics may be influenced by style changes.