Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: Source/core/rendering/style/RenderStyleConstants.h

Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update layout test expectations Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/style/RenderStyleConstants.h
diff --git a/Source/core/rendering/style/RenderStyleConstants.h b/Source/core/rendering/style/RenderStyleConstants.h
index 5efade95d908501ebf1c0578740ca485c7159bc8..a063b9ec5bd9abe64a1dde6bf5258ffb896f7ad1 100644
--- a/Source/core/rendering/style/RenderStyleConstants.h
+++ b/Source/core/rendering/style/RenderStyleConstants.h
@@ -44,41 +44,6 @@ enum PrintColorAdjust {
PrintColorAdjustExact
};
-// The difference between two styles. The following values are used:
-// - StyleDifferenceEqual - The two styles are identical.
-// FIXME: When style difference is context sensitive, RenderStyle::visualInvalidationDiff() may return
-// StyleDifferenceEqual even there is difference. Will resolve the issue when fixing crbug.com/358460.
-// - StyleDifferenceRecompositeLayer - The layer needs its position and transform updated, but no repaint.
-// - StyleDifferenceRepaint - The object just needs to be repainted.
-// - StyleDifferenceRepaintLayer - The layer and its descendant layers need to be repainted.
-// - StyleDifferenceLayoutPositionedMovementOnly - Only the position of this positioned object has been updated.
-// - StyleDifferenceSimplifiedLayout - Only overflow needs to be recomputed.
-// - StyleDifferenceSimplifiedLayoutAndPositionedMovement - Both positioned movement and simplified layout updates are required.
-// - StyleDifferenceLayout - A full layout is required.
-enum StyleDifference {
- StyleDifferenceEqual,
- StyleDifferenceRecompositeLayer,
- StyleDifferenceRepaint,
- StyleDifferenceRepaintLayer,
- StyleDifferenceLayoutPositionedMovementOnly,
- StyleDifferenceSimplifiedLayout,
- StyleDifferenceSimplifiedLayoutAndPositionedMovement,
- StyleDifferenceLayout
-};
-
-// When some style properties change, different amounts of work have to be done depending on
-// context (e.g. whether the property is changing on an element which has a compositing layer).
-// A simple StyleDifference does not provide enough information so we return a bit mask of
-// StyleDifferenceContextSensitiveProperties from RenderStyle::visualInvalidationDiff() too.
-enum StyleDifferenceContextSensitiveProperty {
- ContextSensitivePropertyNone = 0,
- ContextSensitivePropertyTransform = (1 << 0),
- ContextSensitivePropertyOpacity = (1 << 1),
- ContextSensitivePropertyFilter = (1 << 2),
- // The object needs to be repainted if it contains text or properties dependent on color (e.g., border or outline).
- ContextSensitivePropertyTextOrColor = (1 << 3)
-};
-
// Static pseudo styles. Dynamic ones are produced on the fly.
enum PseudoId {
// The order must be NOP ID, public IDs, and then internal IDs.

Powered by Google App Engine
This is Rietveld 408576698