Source/core/rendering/RenderScrollbarPart.cpp - Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderScrollbarPart.cpp

Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase, Fix break Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderScrollbarPart.cpp

diff --git a/Source/core/rendering/RenderScrollbarPart.cpp b/Source/core/rendering/RenderScrollbarPart.cpp

index 5ebcaf1c58d0eb266e9b55944c728ed30d5d3907..927079a1fdff09b7eba07e8f4eb25d91af3728e2 100644

--- a/Source/core/rendering/RenderScrollbarPart.cpp

+++ b/Source/core/rendering/RenderScrollbarPart.cpp

@@ -151,7 +151,7 @@ void RenderScrollbarPart::styleDidChange(StyleDifference diff, const RenderStyle

clearPositionedState();

setFloating(false);

setHasOverflowClip(false);

- if (oldStyle && m_scrollbar && m_part != NoPart && diff >= StyleDifferenceRepaint)

+ if (oldStyle && m_scrollbar && m_part != NoPart && (diff.needsRepaint() || diff.needsLayout()))

m_scrollbar->theme()->invalidatePart(m_scrollbar, m_part);

}

« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/RenderTableRow.cpp » ('j') | no next file with comments »