Source/core/rendering/svg/RenderSVGRoot.cpp - Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGRoot.cpp

Issue 236203020: Separate repaint and layout requirements of StyleDifference (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase; Renaming of some methods and small changes in StyleDifference Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/RenderSVGRoot.cpp

diff --git a/Source/core/rendering/svg/RenderSVGRoot.cpp b/Source/core/rendering/svg/RenderSVGRoot.cpp

index dc5383605f90f1e035c503033a73375a4bb788b1..d2bb90878ded693deff310f867f063411903cc65 100644

--- a/Source/core/rendering/svg/RenderSVGRoot.cpp

+++ b/Source/core/rendering/svg/RenderSVGRoot.cpp

@@ -294,9 +294,10 @@ void RenderSVGRoot::willBeDestroyed()

void RenderSVGRoot::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)

{

- if (diff == StyleDifferenceLayout)

+ if (diff.needsFullLayout())

setNeedsBoundariesUpdate();

- if (diff == StyleDifferenceRepaint) {

+ // FIXME: How about other diff flags?

+ if (diff.needsRepaintObjectOnly()) {

// Box decorations may have appeared/disappeared - recompute status.

m_hasBoxDecorations = calculateHasBoxDecorations();

}